Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754546Ab2BTXaP (ORCPT ); Mon, 20 Feb 2012 18:30:15 -0500 Received: from mail-gx0-f174.google.com ([209.85.161.174]:49173 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754388Ab2BTXaM (ORCPT ); Mon, 20 Feb 2012 18:30:12 -0500 MIME-Version: 1.0 X-Originating-IP: [207.239.114.206] In-Reply-To: References: <1328831277-21002-1-git-send-email-pdeschrijver@nvidia.com> <1328831277-21002-3-git-send-email-pdeschrijver@nvidia.com> Date: Mon, 20 Feb 2012 15:30:11 -0800 Message-ID: Subject: Re: [PATCH v3 02/10] ARM: tegra: export Tegra chipid From: Olof Johansson To: Colin Cross Cc: Peter De Schrijver , Stephen Warren , Russell King , Gary King , Arnd Bergmann , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 733 Lines: 21 Hi, On Mon, Feb 20, 2012 at 3:13 PM, Colin Cross wrote: > Other platforms use accessors for this (cpu_is_xxx(), although > soc_is_xxx() is probably more appropriate). I have previously objected to additions of said functions on tegra, since they tend to start crawling into drivers as runtime tests instead of providing more appropriate detection at probe time. I can be persuaded differently but I haven't yet seen a strong case for changing my mind. :) -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/