Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754754Ab2BTXfL (ORCPT ); Mon, 20 Feb 2012 18:35:11 -0500 Received: from violet.fr.zoreil.com ([92.243.8.30]:47880 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754636Ab2BTXfK (ORCPT ); Mon, 20 Feb 2012 18:35:10 -0500 Date: Tue, 21 Feb 2012 00:22:19 +0100 From: Francois Romieu To: Jonathan Nieder Cc: booster@wolke7.net, hayeswang , "'Eric Dumazet'" , netdev@vger.kernel.org, "'nic_swsd'" , linux-kernel@vger.kernel.org, "'Armin Kazmi'" , Lucas Stach Subject: Re: [PATCH 1/2] r8169: Rx FIFO overflow fixes. Message-ID: <20120220232219.GB13960@electric-eye.fr.zoreil.com> References: <4ED2A573.1020807@wolke7.net> <20111127231147.GA1784@electric-eye.fr.zoreil.com> <20111129105440.GA2410@electric-eye.fr.zoreil.com> <4ED538EC.4010509@wolke7.net> <20111201102000.GA14013@electric-eye.fr.zoreil.com> <4ED7E6AB.6050308@wolke7.net> <20111201222612.GA27998@electric-eye.fr.zoreil.com> <20111205063045.GA3103@electric-eye.fr.zoreil.com> <20120220023740.GA4433@burratino> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120220023740.GA4433@burratino> User-Agent: Mutt/1.4.2.2i X-Organisation: Land of Sunshine Inc. Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 823 Lines: 22 Jonathan Nieder : [...] > What do you think? Is there any way I can help? (E.g., given rough > guidelines about what approach is acceptable I'd be happy to work with > Gerd to produce a tested patch that does (1) and (2) but not (3) for > 3.0.y.) Few guidelines are needed: go for it. I would trust the manufacturer for (3) though. If you still have time to help, you should really try to break davem-next branch. I won't claim it's bug-free but the IRQ / napi / Tx processing in the r8169 driver should now be easier to read and maintain. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/