Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754820Ab2BUAGd (ORCPT ); Mon, 20 Feb 2012 19:06:33 -0500 Received: from e23smtp05.au.ibm.com ([202.81.31.147]:59501 "EHLO e23smtp05.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754745Ab2BUAGc (ORCPT ); Mon, 20 Feb 2012 19:06:32 -0500 Date: Tue, 21 Feb 2012 05:36:22 +0530 From: Srivatsa Vaddagiri To: Mike Galbraith Cc: Peter Zijlstra , Suresh Siddha , linux-kernel , Ingo Molnar , Paul Turner Subject: Re: sched: Avoid SMT siblings in select_idle_sibling() if possible Message-ID: <20120221000622.GH2350@linux.vnet.ibm.com> Reply-To: Srivatsa Vaddagiri References: <1321468646.11680.2.camel@sbsiddha-desk.sc.intel.com> <1321495153.5100.7.camel@marge.simson.net> <1321544313.6308.25.camel@marge.simson.net> <1321545376.2495.1.camel@laptop> <1321547917.6308.48.camel@marge.simson.net> <1321551381.15339.21.camel@sbsiddha-desk.sc.intel.com> <1321629267.7080.13.camel@marge.simson.net> <1329748861.2293.345.camel@twins> <20120220150348.GC2350@linux.vnet.ibm.com> <1329762343.6276.156.camel@marge.simpson.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1329762343.6276.156.camel@marge.simpson.net> User-Agent: Mutt/1.5.21 (2010-09-15) x-cbid: 12022014-1396-0000-0000-000000B3B82B Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 938 Lines: 23 * Mike Galbraith [2012-02-20 19:25:43]: > > I can give that a try for my benchmark and see how much it helps. My > > suspicion is it will not fully solve the problem I have on hand. > > I doubt it will either. Your problem is when it doesn't succeed, but > you have an idle core available in another domain. fwiw the patch I had sent does a wakeup balance within prev_cpu's cache_domain (and not outside). It handles the case where we don't have any idle cpu/core within prev_cpu's cache domain, in which case we look for next best thing (least loaded cpu). I did see good numbers with that (for both my benchmark and sysbench). More on this later in the day .. - vatsa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/