Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752193Ab2BUFfu (ORCPT ); Tue, 21 Feb 2012 00:35:50 -0500 Received: from terminus.zytor.com ([198.137.202.10]:40563 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768Ab2BUFft (ORCPT ); Tue, 21 Feb 2012 00:35:49 -0500 References: <4F42FE08.5020309@zytor.com> User-Agent: K-9 Mail for Android In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2 3/3] i387: support lazy restore of FPU state From: "H. Peter Anvin" Date: Mon, 20 Feb 2012 21:35:16 -0800 To: Linus Torvalds CC: Josh Boyer , Jongman Heo , Thomas Gleixner , Ingo Molnar , x86@kernel.org, Linux Kernel Mailing List Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1504 Lines: 40 Running build tests now; will check results in the morning. Linus Torvalds wrote: >On Mon, Feb 20, 2012 at 6:14 PM, H. Peter Anvin wrote: >> On 02/20/2012 06:10 PM, Linus Torvalds wrote: >>> >>> Although I do wonder if we should just make kernel_fpu_begin() be a >>> real function instead of inlining it. I'm not sure it makes sense to >>> inline that thing, and it might be better to export that one >instead. >>> Comments? >> >> I would agree with that. > >So I have a patch that does that, but it's noticeably bigger. > >It uninlines a fair amount of i387.h, and moves it into i387.c. I do >think it's probably the right thing to do, though. > >I did a "make allmodconfig" with this on x86-64, but it's quite >possible that x86-32 does additional cases. Does this patch work for >people? > >(This is *on*top*of* the quick "let's just get it to work" patch that >just exports the new percpu variable. I already committed that and >pushed it out, since I wanted a quick fix so that people wouldn't be >held up by this) > >IOW, if you can try this on top of current -git, that would be lovely. > > Linus -- Sent from my mobile phone. Please excuse my brevity and lack of formatting. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/