Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754423Ab2BUKkR (ORCPT ); Tue, 21 Feb 2012 05:40:17 -0500 Received: from mail.skyhub.de ([78.46.96.112]:49457 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751339Ab2BUKkP (ORCPT ); Tue, 21 Feb 2012 05:40:15 -0500 Date: Tue, 21 Feb 2012 11:40:20 +0100 From: Borislav Petkov To: Kevin Winchester Cc: Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner , Randy Dunlap , Nick Bowler , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] x86: Move per cpu cpu_llc_id to a field in struct cpuinfo_x86 Message-ID: <20120221104020.GB2486@x1.osrc.amd.com> Mail-Followup-To: Borislav Petkov , Kevin Winchester , Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner , Randy Dunlap , Nick Bowler , linux-kernel@vger.kernel.org References: <20120217115627.GA25601@elte.hu> <1329789966-693-1-git-send-email-kjwinchester@gmail.com> <1329789966-693-3-git-send-email-kjwinchester@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1329789966-693-3-git-send-email-kjwinchester@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1461 Lines: 38 On Mon, Feb 20, 2012 at 10:06:03PM -0400, Kevin Winchester wrote: > This simplifies the various code paths using this field as it > groups the per-cpu data together. > > Signed-off-by: Kevin Winchester > --- > arch/x86/include/asm/processor.h | 2 ++ > arch/x86/include/asm/smp.h | 2 -- > arch/x86/kernel/apic/apic_numachip.c | 2 +- > arch/x86/kernel/cpu/amd.c | 14 ++++---------- > arch/x86/kernel/cpu/common.c | 1 + > arch/x86/kernel/cpu/intel_cacheinfo.c | 11 ++--------- > arch/x86/kernel/smpboot.c | 18 ++++++++---------- > 7 files changed, 18 insertions(+), 32 deletions(-) > > diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h > index 0c8b574..2d4eb6f 100644 > --- a/arch/x86/include/asm/processor.h > +++ b/arch/x86/include/asm/processor.h > @@ -111,6 +111,8 @@ struct cpuinfo_x86 { > u16 cpu_index; > u32 microcode; > cpumask_t llc_shared_map; > + /* cpus sharing the last level cache: */ Just a minor nitpick which I forgot: we spell "CPUs" in the comments as in the next patch you're adding a comment about the sibling_map. Thanks. -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/