Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754880Ab2BULjz (ORCPT ); Tue, 21 Feb 2012 06:39:55 -0500 Received: from ch1ehsobe006.messaging.microsoft.com ([216.32.181.186]:49893 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753794Ab2BULjy (ORCPT ); Tue, 21 Feb 2012 06:39:54 -0500 X-SpamScore: -9 X-BigFish: VPS-9(zz1432N98dKzz1202hzzz2dh2a8h668h839h93fh) X-Forefront-Antispam-Report: CIP:59.163.77.45;KIP:(null);UIP:(null);IPV:NLI;H:Outbound.kpitcummins.com;RD:59.163.77.45.static.vsnl.net.in;EFVD:NLI Subject: Re: [PATCH 01/01] MFD: add ADC support to DA9052/53 MFD core v2 From: Ashish Jangam To: CC: , , , In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Date: Tue, 21 Feb 2012 17:01:37 +0530 Message-ID: <1329823897.30549.175.camel@dhruva> MIME-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.10.38.47] X-OriginatorOrg: kpitcummins.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1306 Lines: 22 > On Mon, Feb 20, 2012 at 12:07:27PM +0000, Arnd Bergmann wrote: > > > Also, I would recommend using request_irq instead of > > request_threaded_irq here because the function only has a single > > "complete()" call in it, just like a threaded IRQ handler has. There > > is no point going through another thread just to wake up the one that is blocked. > > Actually in this case that won't work as the interrupt is generated by the chip interrupt controller and as the chip is I2C/SPI controlled it is itself threaded and can only generate threaded interrupts as genirq can't get back into hard interrupt context. > > As a result of this restriction when an interrupt handler doesn't care what context it runs in it's better to use request_any_context_irq(). > This will do a normal IRQ when it can but will bind successfully to a threaded IRQ if that's what's provided. as threaded IRQs are only being used, request_any_context_irq() will internally call request_threaded_irq() so is there any other need to replace the current request_threaded_irq()? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/