Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755227Ab2BUNZm (ORCPT ); Tue, 21 Feb 2012 08:25:42 -0500 Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:56587 "EHLO mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754863Ab2BUNZl convert rfc822-to-8bit (ORCPT ); Tue, 21 Feb 2012 08:25:41 -0500 MIME-Version: 1.0 In-Reply-To: <1329682829-24347-1-git-send-email-przemo@firszt.eu> References: <1329682829-24347-1-git-send-email-przemo@firszt.eu> Date: Tue, 21 Feb 2012 07:25:39 -0600 Message-ID: Subject: Re: [PATCH] HID: wacom: fix proximity tool release From: Chris Bagwell To: Przemo Firszt Cc: aris@redhat.com, jkosina@suse.cz, pinglinux@gmail.com, linuxwacom-devel@lists.sourceforge.net, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1541 Lines: 40 Reviewed-by: Chris Bagwell On Sun, Feb 19, 2012 at 2:20 PM, Przemo Firszt wrote: > Don't zero the current tool before reporting its release to the input > subsystem. > > Signed-off-by: Aristeu Rozanski > Tested-by: Przemo Firszt > --- > ?drivers/hid/hid-wacom.c | ? ?2 +- > ?1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c > index 0621047..696b907 100644 > --- a/drivers/hid/hid-wacom.c > +++ b/drivers/hid/hid-wacom.c > @@ -322,10 +322,10 @@ static void wacom_i4_parse_pen_report(struct wacom_data *wdata, > > ? ? ? ?switch (data[1]) { > ? ? ? ?case 0x80: /* Out of proximity report */ > - ? ? ? ? ? ? ? wdata->tool = 0; > ? ? ? ? ? ? ? ?input_report_key(input, BTN_TOUCH, 0); > ? ? ? ? ? ? ? ?input_report_abs(input, ABS_PRESSURE, 0); > ? ? ? ? ? ? ? ?input_report_key(input, wdata->tool, 0); > + ? ? ? ? ? ? ? wdata->tool = 0; > ? ? ? ? ? ? ? ?input_sync(input); > ? ? ? ? ? ? ? ?break; > ? ? ? ?case 0xC2: /* Tool report */ > -- > 1.7.6.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at ?http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/