Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755388Ab2BUOT0 (ORCPT ); Tue, 21 Feb 2012 09:19:26 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:47533 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753083Ab2BUOTZ (ORCPT ); Tue, 21 Feb 2012 09:19:25 -0500 Authentication-Results: mr.google.com; spf=pass (google.com: domain of jwboyer@gmail.com designates 10.180.92.227 as permitted sender) smtp.mail=jwboyer@gmail.com; dkim=pass header.i=jwboyer@gmail.com MIME-Version: 1.0 In-Reply-To: References: <4F42FE08.5020309@zytor.com> Date: Tue, 21 Feb 2012 09:19:24 -0500 Message-ID: Subject: Re: [PATCH v2 3/3] i387: support lazy restore of FPU state From: Josh Boyer To: Linus Torvalds Cc: "H. Peter Anvin" , Jongman Heo , Thomas Gleixner , Ingo Molnar , x86@kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1523 Lines: 37 On Tue, Feb 21, 2012 at 12:27 AM, Linus Torvalds wrote: > On Mon, Feb 20, 2012 at 6:14 PM, H. Peter Anvin wrote: >> On 02/20/2012 06:10 PM, Linus Torvalds wrote: >>> >>> Although I do wonder if we should just make kernel_fpu_begin() be a >>> real function instead of inlining it. I'm not sure it makes sense to >>> inline that thing, and it might be better to export that one instead. >>> Comments? >> >> I would agree with that. > > So I have a patch that does that, but it's noticeably bigger. > > It uninlines a fair amount of i387.h, and moves it into i387.c. I do > think it's probably the right thing to do, though. > > I did a "make allmodconfig" with this on x86-64, but it's quite > possible that x86-32 does additional cases. Does this patch work for > people? > > (This is *on*top*of* the quick "let's just get it to work" patch that > just exports the new percpu variable. I already committed that and > pushed it out, since I wanted a quick fix so that people wouldn't be > held up by this) > > IOW, if you can try this on top of current -git, that would be lovely. The quick patch cleared up the build issue I was seeing. Thanks for the quick fix. I'll try building with this one a bit later today as well. josh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/