Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755889Ab2BUWTv (ORCPT ); Tue, 21 Feb 2012 17:19:51 -0500 Received: from mga02.intel.com ([134.134.136.20]:39312 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754176Ab2BUWTu (ORCPT ); Tue, 21 Feb 2012 17:19:50 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.67,352,1309762800"; d="scan'208";a="110548125" Subject: Re: [PATCH v2 3/3] i387: support lazy restore of FPU state From: Suresh Siddha Reply-To: Suresh Siddha To: Linus Torvalds Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Linux Kernel Mailing List Date: Tue, 21 Feb 2012 14:19:35 -0800 In-Reply-To: References: <1329861273.29790.261.camel@sbsiddha-desk.sc.intel.com> Organization: Intel Corp Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.0.3 (3.0.3-1.fc15) Content-Transfer-Encoding: 7bit Message-ID: <1329862775.29790.268.camel@sbsiddha-desk.sc.intel.com> Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 923 Lines: 30 On Tue, 2012-02-21 at 13:57 -0800, Linus Torvalds wrote: > On Tue, Feb 21, 2012 at 1:54 PM, Suresh Siddha > wrote: > > > > Reviewing this code, I think we need to set the 'last_cpu' to an invalid > > number in the fpu_alloc too. Appended is the patch. > > I cleared fpu_counter in copy_thread() instead. Hmm, didn't pay attention to that patch. Too many patches ;( > Doing this in fpu_alloc() isn't necessarily a bad idea, though. yes, I think we should do this in fpu_alloc() or bit more explicitly by updating 'last_cpu' in copy_thread(). Someone experimenting with removing fpu pre-load may not realize this subtle issue. thanks, suresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/