Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756256Ab2BUXUG (ORCPT ); Tue, 21 Feb 2012 18:20:06 -0500 Received: from mail-we0-f174.google.com ([74.125.82.174]:38594 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752894Ab2BUXUE (ORCPT ); Tue, 21 Feb 2012 18:20:04 -0500 MIME-Version: 1.0 In-Reply-To: <1329865848.18384.64.camel@edumazet-laptop> References: <1329865848.18384.64.camel@edumazet-laptop> From: Linus Torvalds Date: Tue, 21 Feb 2012 15:19:43 -0800 X-Google-Sender-Auth: zUsaAudfHrTL6QeA0XbZkwRmBsI Message-ID: Subject: Re: Linux 3.3-rc4 To: Eric Dumazet Cc: Thomas Meyer , Al Viro , Linux Kernel Mailing List , linux-fsdevel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1287 Lines: 31 On Tue, Feb 21, 2012 at 3:10 PM, Eric Dumazet wrote: > > Yep, this is what I thought, but when this was raised last september, > both Andrew and Andi disagreed. > > https://lkml.org/lkml/2011/10/6/389 Well, I agree that it *could* break things, but considering that at least glibc does the sign-exitension, any code that puts a large number in the 'timeout' field would *already* have broken. Which is why I think we should first try to fix the system call interface - because it's the simpler patch, and it's the RightThing(tm) to do from a standards standpoint. It's also almost guaranteed to work, exactly because of how glibc already does that conversion. But if something does break - however unlikely and perverse the code has to be to be able to do that - we'd clearly have to undo that "just fix sys_poll()" and use Thomas' patch to have a compat_sys_poll() instead. I just don't like the notion of doing that silly compat thing when it really shouldn't be needed to begin with. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/