Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752959Ab2BVGkQ (ORCPT ); Wed, 22 Feb 2012 01:40:16 -0500 Received: from mga02.intel.com ([134.134.136.20]:5140 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751830Ab2BVGkO (ORCPT ); Wed, 22 Feb 2012 01:40:14 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.67,352,1309762800"; d="scan'208";a="110668968" Message-ID: <4F448DAA.6000207@linux.intel.com> Date: Tue, 21 Feb 2012 22:39:38 -0800 From: Darren Hart User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 MIME-Version: 1.0 To: Tomoya MORINAGA CC: Linux Kernel Mailing List , Feng Tang , Greg Kroah-Hartman , Alan Cox , linux-serial@vger.kernel.org Subject: Re: [PATCH 0/4] pch_uart: Cleanups, board quirks, and user uartclk parameter References: <4F4462B8.6030607@linux.intel.com> In-Reply-To: X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1369 Lines: 31 On 02/21/2012 08:26 PM, Tomoya MORINAGA wrote: > 2012年2月22日12:36 Darren Hart : >> This patch series allows for a functional early serial console as well >> as using the UART after boot. It leaves the CM-iTC board alone. So this >> seems to enable all use cases, while forcing 192MHz breaks the FRI2 >> early serial console. I don't see an advantage to that approach other >> than the obviously simpler code (which is nice, but should not trump >> functionality). > > Your quark "Fish River Island II" is OK. > My concern is default uart_clock remains 1.8432 MHz. > Like I said the advantage before, I think this should be 192MHz not 1.8432 MHz. > > Or do you have any reason 1.8432 MHz should be set as PCH_UART default clock. Ah, that's a good point. We can add a patch to this series that sets the default to 192MHz, drops the CM-iTC quirk, and does nothing in pch_phub probe for the FRI2. Would you care to Ack this series and then follow-up with a patch set the default clock to 192MHz? -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/