Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753043Ab2BVGsu (ORCPT ); Wed, 22 Feb 2012 01:48:50 -0500 Received: from tx2ehsobe001.messaging.microsoft.com ([65.55.88.11]:42043 "EHLO TX2EHSOBE001.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751461Ab2BVGst (ORCPT ); Wed, 22 Feb 2012 01:48:49 -0500 X-SpamScore: -10 X-BigFish: VS-10(zz9371I1432N98dKzz1202hzz8275bhz2dh2a8h668h839h944h) X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI Date: Wed, 22 Feb 2012 14:56:48 +0800 From: Dong Aisheng To: Linus Walleij CC: Stephen Warren , Linus Walleij , , , , , , , , Mark Brown Subject: Re: [PATCH 11/20] pinctrl: Downgrade pinctrl_get warning when no maps are found Message-ID: <20120222065647.GE11087@shlinux2.ap.freescale.net> References: <1329720360-23227-1-git-send-email-swarren@nvidia.com> <1329720360-23227-12-git-send-email-swarren@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1399 Lines: 33 On Tue, Feb 21, 2012 at 02:51:55PM +0100, Linus Walleij wrote: > On Mon, Feb 20, 2012 at 7:45 AM, Stephen Warren wrote: > > > This may be perfectly legitimate. An IP block may get re-used > > across SoCs. Not all of those SoCs may need pinmux settings for the > > IP block, e.g. if one SoC dedicates pins to that function but > > another doesn't. The driver won't know this, and will always > > attempt to set up the pinmux. The mapping table defines whether any > > HW programming is actually needed. > > > > Signed-off-by: Stephen Warren > > This is equivalent to providing dummy pincontrollers as was on my > TODO for a while admittedly. > > For consistency with regulators it would maybe be better to have > optional dummy pin controllers but after thinking a bit about it > I think this is more helpful, so I applied it anyway. > > However I would invite more opinions... > I'm afraid this is a little error-prone, that means even we specifed the wrong map name or state name, the pinctrl_get still does not get failed and it is a little different as what we want in this patch. Regards Dong Aisheng -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/