Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755258Ab2BVJqe (ORCPT ); Wed, 22 Feb 2012 04:46:34 -0500 Received: from he.sipsolutions.net ([78.46.109.217]:54627 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754175Ab2BVJqc (ORCPT ); Wed, 22 Feb 2012 04:46:32 -0500 Subject: RE: [PATCH] checkpatch: Add some --strict coding style checks From: Johannes Berg To: David Laight Cc: "Allan, Bruce W" , Joe Perches , David Miller , Andy Whitcroft , Andrew Morton , andrei.emeltchenko.news@gmail.com, linville@tuxdriver.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: (sfid-20120222_103559_848738_672B22CE) References: (sfid-20120222_103559_848738_672B22CE) Content-Type: text/plain; charset="UTF-8" Date: Wed, 22 Feb 2012 10:46:14 +0100 Message-ID: <1329903974.4657.0.camel@jlt3.sipsolutions.net> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 803 Lines: 23 On Wed, 2012-02-22 at 09:35 +0000, David Laight wrote: > > if (!(func_a(x) && > > func_b(y))) > > baz(); > > Gah - that is horrid for the 'preferred style'. > A quick glance at the code puts both the func_b() > and baz() calls as inside the if. You forgot to read/quote the rest of Allan's email: > Assuming my stupid mailer will screw up the indentation above, the 'a' > in addr in the first example is meant to be immediately below the 'n' > in nr, and the two 'f's in func_* are meant to be vertically lined up > in the second example. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/