Date: Wed, 22 Feb 2012 07:55:16 -0600 (CST)
From: Christoph Lameter <cl@linux.com>
To: Rafael Aquini <aquini@redhat.com>
cc: linux-mm@kvack.org, Randy Dunlap <rdunlap@xenotime.net>,
        Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
        Rik van Riel <riel@redhat.com>, Josef Bacik <josef@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] oom: add sysctl to enable slab memory dump
In-Reply-To: <20120222115320.GA3107@x61.redhat.com>
Message-ID: <alpine.DEB.2.00.1202220754140.21637@router.home>
References: <20120222115320.GA3107@x61.redhat.com>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 696
Lines: 23

On Wed, 22 Feb 2012, Rafael Aquini wrote:

> --- a/mm/slub.c
> +++ b/mm/slub.c
> +void oom_dump_slabs(int ratio)
> +{

> +
> +		for_each_online_node(node) {
> +			struct kmem_cache_node *n = get_node(cachep, node);
> +			if (!n)
> +				continue;
> +
> +			nr_objs += atomic_long_read(&n->total_objects);

Please use node_nr_objects() instead of directly accessing total_objects.
total_objects are only available if debugging support was compiled in.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/