Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756014Ab2BVWWp (ORCPT ); Wed, 22 Feb 2012 17:22:45 -0500 Received: from mail-pz0-f46.google.com ([209.85.210.46]:62022 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755764Ab2BVWWo (ORCPT ); Wed, 22 Feb 2012 17:22:44 -0500 Authentication-Results: mr.google.com; spf=pass (google.com: domain of rmallon@gmail.com designates 10.68.227.36 as permitted sender) smtp.mail=rmallon@gmail.com; dkim=pass header.i=rmallon@gmail.com Message-ID: <4F456AAF.3090809@gmail.com> Date: Thu, 23 Feb 2012 09:22:39 +1100 From: Ryan Mallon User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.26) Gecko/20120131 Lightning/1.0b2 Thunderbird/3.1.18 MIME-Version: 1.0 To: Nicolas Ferre CC: plagnioj@jcrosoft.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux@arm.linux.org.uk Subject: Re: [PATCH v2 02/19] ARM: at91/at91x40: remove use of at91_sys_read/write References: <1329903585-30738-1-git-send-email-nicolas.ferre@atmel.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1469 Lines: 38 On 22/02/12 20:39, Nicolas Ferre wrote: > From: Jean-Christophe PLAGNIOL-VILLARD > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > Acked-by: Nicolas Ferre > --- > arch/arm/mach-at91/at91x40.c | 2 +- > arch/arm/mach-at91/at91x40_time.c | 28 +++++++++++++++++----------- > arch/arm/mach-at91/include/mach/at91x40.h | 18 +++++++++--------- > 3 files changed, 27 insertions(+), 21 deletions(-) > > diff --git a/arch/arm/mach-at91/at91x40.c b/arch/arm/mach-at91/at91x40.c > index 0154b7f..5400a1d 100644 > --- a/arch/arm/mach-at91/at91x40.c > +++ b/arch/arm/mach-at91/at91x40.c > @@ -44,7 +44,7 @@ static void at91x40_idle(void) > * Disable the processor clock. The processor will be automatically > * re-enabled by an interrupt or by a reset. > */ > - at91_sys_write(AT91_PS_CR, AT91_PS_CR_CPU); > + __raw_writel(AT91_PS_CR_CPU, AT91_PS_CR); This doesn't seem to be equivalent, at91_sys_write does: void __iomem *addr = (void __iomem *)AT91_VA_BASE_SYS; __raw_writel(value, addr + reg_offset); and this patch doesn't redefine AT91_PS_CR. Was it broken before this patch? What am I missing? ~Ryan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/