Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753832Ab2BWAL0 (ORCPT ); Wed, 22 Feb 2012 19:11:26 -0500 Received: from mail-qw0-f53.google.com ([209.85.216.53]:54068 "EHLO mail-qw0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753705Ab2BWALZ convert rfc822-to-8bit (ORCPT ); Wed, 22 Feb 2012 19:11:25 -0500 Authentication-Results: mr.google.com; spf=pass (google.com: domain of mcgrathr@google.com designates 10.229.78.215 as permitted sender) smtp.mail=mcgrathr@google.com; dkim=pass header.i=mcgrathr@google.com MIME-Version: 1.0 In-Reply-To: References: <1329845435-2313-1-git-send-email-wad@chromium.org> <1329845435-2313-7-git-send-email-wad@chromium.org> <9edbabb2262e3d91a7b8c75dbec03d7f.squirrel@webmail.greenhost.nl> From: Roland McGrath Date: Wed, 22 Feb 2012 16:11:01 -0800 Message-ID: Subject: Re: [PATCH v10 07/11] signal, x86: add SIGSYS info and make it synchronous. To: Andrew Lutomirski Cc: Will Drewry , Indan Zupancic , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, kernel-hardening@lists.openwall.com, netdev@vger.kernel.org, x86@kernel.org, arnd@arndb.de, davem@davemloft.net, hpa@zytor.com, mingo@redhat.com, oleg@redhat.com, peterz@infradead.org, rdunlap@xenotime.net, tglx@linutronix.de, eparis@redhat.com, serge.hallyn@canonical.com, djm@mindrot.org, scarybeasts@gmail.com, pmoore@redhat.com, akpm@linux-foundation.org, corbet@lwn.net, eric.dumazet@gmail.com, markus@chromium.org, keescook@chromium.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 965 Lines: 16 On Wed, Feb 22, 2012 at 3:38 PM, Andrew Lutomirski wrote: > I wonder if it would be helpful to change the semantics of RET_KILL > slightly. ?Rather than killing via do_exit, what if it killed via a > forcibly-fatal SIGSYS? ?That way, the parent's waitid() / SIGCHLD > would indicate CLD_KILLED with si_status == SIGSYS. ?The parent could > check that and report that the child was probably compromised. That would be better. But it is certainly a more complex code path, which makes the security weenies twitch. As to concrete issues, any "normal" path needs the changes that are maybe pending from Oleg to make it actually abort the syscall instead of completing it before getting to the signal path. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/