Date: Thu, 23 Feb 2012 14:19:43 +0100
From: Alexander Gordeev <agordeev@redhat.com>
To: Oleg Nesterov <onestero@redhat.com>
Cc: Oleg Nesterov <oleg@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] genirq: Mark IRQ thread handlers with irq_thread flag
Message-ID: <20120223131942.GC1978@dhcp-26-207.brq.redhat.com>
References: <20120220173156.GE9313@dhcp-26-207.brq.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20120220173156.GE9313@dhcp-26-207.brq.redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1000
Lines: 28

Олег,

Ты совершенно прав. Эта проверка -- кривая. Мне лучше отправить self-nack на
этот конкретный патч или заслать всю серию без этого патча заново?

> --- a/kernel/exit.c
> +++ b/kernel/exit.c
> @@ -896,7 +896,7 @@ void do_exit(long code)
>  
>  	WARN_ON(blk_needs_flush_plug(tsk));
>  
> -	if (unlikely(in_interrupt()))
> +	if (unlikely(!tsk->irq_thread && in_interrupt()))
>  		panic("Aiee, killing interrupt handler!");
>  	if (unlikely(!tsk->pid))
>  		panic("Attempted to kill the idle task!");
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index a94466d..d02d4f6 100644

-- 
Regards,
Alexander Gordeev
agordeev@redhat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/