Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754209Ab2BWQ27 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 23 Feb 2012 11:28:59 -0500
Received: from mail-gx0-f174.google.com ([209.85.161.174]:56415 "EHLO
	mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753367Ab2BWQ26 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 23 Feb 2012 11:28:58 -0500
Authentication-Results: mr.google.com; spf=pass (google.com: domain of arnaldo.melo@gmail.com designates 10.236.78.6 as permitted sender) smtp.mail=arnaldo.melo@gmail.com; dkim=pass header.i=arnaldo.melo@gmail.com
Date: Thu, 23 Feb 2012 14:28:50 -0200
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Pekka Enberg <penberg@kernel.org>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] perf report: Add a simple GTK2-based 'perf report'
 browser
Message-ID: <20120223162850.GC25177@infradead.org>
References: <1330013922-3332-1-git-send-email-penberg@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1330013922-3332-1-git-send-email-penberg@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2410
Lines: 82

Em Thu, Feb 23, 2012 at 06:18:42PM +0200, Pekka Enberg escreveu:
> This patch adds a simple GTK2-based browser to 'perf report' that's based on
> the TTY-based browser in builtin-report.c.
> 
> Please not that you need to use
> 
>   make WERROR=0
> 
> to build perf on Fedora 15 (and possibly other distributions) because GTK
> headers do not compile cleanly:
> 
>       CC util/gtk/browser.o
>   In file included from /usr/include/gtk-2.0/gtk/gtk.h:234:0,
>                    from util/gtk/browser.c:7:
>   /usr/include/gtk-2.0/gtk/gtkitemfactory.h:47:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
> 
> To launch "perf report" using the new GTK interface just type:
> 
>   ./perf report --gtk
> 
> The interface is somewhat limited in features at the moment:
> 
>   - No callgraph support
> 
>   - No KVM guest profiling support
> 
>   - No color coding for percentages
> 
>   - No sorting from the UI
> 
>   - ..and many, many more!
> 
> That said, I think this patch a reasonable start to build future features on.

<SNIP>

> +	for (nd = rb_first(&hists->entries); nd; nd = rb_next(nd)) {
> +		struct hist_entry *h = rb_entry(nd, struct hist_entry, rb_node);
> +		GtkTreeIter iter;
> +		double percent;
> +		char s[512];
> +
> +		if (h->filtered)
> +			continue;
> +
> +		gtk_list_store_append(store, &iter);
> +
> +		col_idx = 0;
> +
> +		percent = (h->period * 100.0) / total_period;
> +
> +		snprintf(s, ARRAY_SIZE(s), "%.2f", percent);
> +
> +		gtk_list_store_set(store, &iter, col_idx++, s, -1);
> +
> +		list_for_each_entry(se, &hist_entry__sort_list, list) {
> +			if (se->elide)
> +				continue;
> +
> +			se->se_snprintf(h, s, ARRAY_SIZE(s),
> +					hists__col_len(hists, se->se_width_idx));
> +
> +			gtk_list_store_set(store, &iter, col_idx++, s, -1);
> +		}
> +	}

This is what I avoided by writing a tree widget for the TUI, I really
didn't want to traverse _all_ the hists just to show the ones that
appear in the screen.

Isn't there a way to ask GTK to ask a callback to provide a
representation for the Nth hist entry, i.e. just the ones it _needs_ to
render the screen?

Anyway, great to see this work!

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/