Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753173Ab2BWQtQ (ORCPT ); Thu, 23 Feb 2012 11:49:16 -0500 Received: from hqemgate04.nvidia.com ([216.228.121.35]:3695 "EHLO hqemgate04.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799Ab2BWQtO convert rfc822-to-8bit (ORCPT ); Thu, 23 Feb 2012 11:49:14 -0500 X-PGP-Universal: processed; by hqnvupgp06.nvidia.com on Thu, 23 Feb 2012 08:48:58 -0800 From: Stephen Warren To: Linus Walleij CC: Linus Walleij , "B29396@freescale.com" , "s.hauer@pengutronix.de" , "dongas86@gmail.com" , "shawn.guo@linaro.org" , "thomas.abraham@linaro.org" , "tony@atomide.com" , "linux-kernel@vger.kernel.org" Date: Thu, 23 Feb 2012 08:48:56 -0800 Subject: RE: [PATCH 20/20] pinctrl: Enhance mapping table to support pin config operations Thread-Topic: [PATCH 20/20] pinctrl: Enhance mapping table to support pin config operations Thread-Index: Aczx8ZTr0108S81NQBC8o/dSco+xUgAWS7ig Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF17BD8BC978@HQMAIL01.nvidia.com> References: <1329720360-23227-1-git-send-email-swarren@nvidia.com> <1329720360-23227-21-git-send-email-swarren@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1353 Lines: 33 Linus Walleij wrote at Wednesday, February 22, 2012 11:09 PM: > On Mon, Feb 20, 2012 at 7:46 AM, Stephen Warren wrote: ... > > @@ -1022,7 +1074,7 @@ Since it may be common to request the core to hog a few always-applicable > > ?mux settings on the primary pin controller, there is a convenience macro for > > ?this: > > > > -PIN_MAP_SYS_HOG("active", "pinctrl-foo", "power_func") > > +PIN_MAP_MUX_GROUP("pinctrl-foo", "active", "pinctrl-foo", NULL, "power_func") > > Please keep the explicit _HOG macros for readability. Relying on > the implicit relation between dev and pctldev being the same and to be > parsed by humans is vulnerable. > > PIN_MAP_MUX_GROUP_HOG() OK, I guess I can add some of those back. The main reason I removed the special-cases was to avoid consumer.h being chock full of a ton of different macros you had to choose from. This wasn't so much of an issue before, but since the number of macros has grown now to support pin config, dummy states, etc., it seemed cluttered. Still, I guess they're useful, so I can add them back since you asked. -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/