Subject: Re: [PATCH] perf report: Add a simple GTK2-based 'perf report'
 browser
From: Colin Walters <walters@verbum.org>
To: Pekka Enberg <penberg@kernel.org>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
        Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Date: Thu, 23 Feb 2012 14:36:41 -0500
In-Reply-To: <1330013922-3332-1-git-send-email-penberg@kernel.org>
References: <1330013922-3332-1-git-send-email-penberg@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Message-ID: <1330025802.17301.1.camel@lenny>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1036
Lines: 29

On Thu, 2012-02-23 at 18:18 +0200, Pekka Enberg wrote:
> This patch adds a simple GTK2-based browser to 'perf report' that's based on
> the TTY-based browser in builtin-report.c.
> 
> Please not that you need to use
> 
>   make WERROR=0

You could -Wnoerror=strict-prototypes...

> 
> to build perf on Fedora 15 (and possibly other distributions) because GTK
> headers do not compile cleanly:
> 
>       CC util/gtk/browser.o
>   In file included from /usr/include/gtk-2.0/gtk/gtk.h:234:0,
>                    from util/gtk/browser.c:7:
>   /usr/include/gtk-2.0/gtk/gtkitemfactory.h:47:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]

Unfortunately it was a historical mistake, but it's part of the public
API:

https://bugzilla.gnome.org/show_bug.cgi?id=508760

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/