Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757261Ab2BWWg1 (ORCPT ); Thu, 23 Feb 2012 17:36:27 -0500 Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:41927 "EHLO mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755095Ab2BWWgX (ORCPT ); Thu, 23 Feb 2012 17:36:23 -0500 MIME-Version: 1.0 In-Reply-To: References: <1329845435-2313-1-git-send-email-wad@chromium.org> <1329845435-2313-7-git-send-email-wad@chromium.org> <9edbabb2262e3d91a7b8c75dbec03d7f.squirrel@webmail.greenhost.nl> <4F45887A.5010809@zytor.com> <4F459109.1060205@zytor.com> Date: Thu, 23 Feb 2012 16:36:21 -0600 Message-ID: Subject: Re: [PATCH v10 07/11] signal, x86: add SIGSYS info and make it synchronous. From: Will Drewry To: Markus Gutschke Cc: Indan Zupancic , Roland McGrath , "H. Peter Anvin" , Kees Cook , Andrew Lutomirski , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, kernel-hardening@lists.openwall.com, netdev@vger.kernel.org, x86@kernel.org, arnd@arndb.de, davem@davemloft.net, mingo@redhat.com, oleg@redhat.com, peterz@infradead.org, rdunlap@xenotime.net, tglx@linutronix.de, eparis@redhat.com, serge.hallyn@canonical.com, djm@mindrot.org, scarybeasts@gmail.com, pmoore@redhat.com, akpm@linux-foundation.org, corbet@lwn.net, eric.dumazet@gmail.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1738 Lines: 37 On Thu, Feb 23, 2012 at 4:33 PM, Markus Gutschke wrote: > On Thu, Feb 23, 2012 at 14:15, Indan Zupancic wrote: >> What about making SECCOMP_RET_TRAP dump core/send SIGSYS if there is >> no tracer with PTRACE_O_SECCOMP set? > > Please don't make things dependent on having a tracer. There are > applications that don't really need a tracer; in fact, these are > typically the exact same applications that can benefit from receiving > SIGSYS and then handling it internally. > > If a tracer was required to set this up, it would make it difficult to > use gdb, strace, or any other common debugging tools. > >> Sending SIGSYS is useful, but it's quite a bit less useful if user >> space can't handle it in a signal handler, so I don't think it's >> worth it to make a unblockable version. > > Maybe, I am not parsing your e-mail correctly. But don't we already > get the desired behavior, if SIGSYS is treated the same as any other > synchronous signal? If it is unblocked and has a handler, the > application can decide to handle it. If neither one of these > conditions is true, it terminates the program. Ulimits and > PR_SET_DUMPABLE determine whether a core file is generated. Yeah - the current patchset does that just fine. The tweak I was proposing was making ti possible to deliver an SIGSYS that always uses SIG_DFL so that you don't have to play with signal call enforcement in the filters. This is a pretty minor tweak either way. cheers! will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/