Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756152Ab2BXEr2 (ORCPT ); Thu, 23 Feb 2012 23:47:28 -0500 Received: from terminus.zytor.com ([198.137.202.10]:59061 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755752Ab2BXEr0 (ORCPT ); Thu, 23 Feb 2012 23:47:26 -0500 Message-ID: <4F471651.3080609@zytor.com> Date: Thu, 23 Feb 2012 20:47:13 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 MIME-Version: 1.0 To: Yinghai Lu CC: matt.fleming@intel.com, mingo@redhat.com, mjg@redhat.com, linux-kernel@vger.kernel.org, keithp@keithp.com, rui.zhang@intel.com, huang.ying.caritas@gmail.com, stable@vger.kernel.org, tglx@linutronix.de, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/urgent] x86, efi: Delete efi_ioremap() and fix CONFIG_X86_32 oops References: <1329744626-5036-1-git-send-email-matt@console-pimps.org> <4F45B35D.1010702@zytor.com> In-Reply-To: X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1458 Lines: 39 On 02/23/2012 02:36 AM, Yinghai Lu wrote: > On Wed, Feb 22, 2012 at 7:32 PM, H. Peter Anvin wrote: >> On 02/22/2012 06:20 PM, Yinghai Lu wrote: >>> >>> Why is MAXMEM used here? >>> >>> EFI reserved area could be above 4G? >>> >>> if that is the case, you will map all mmio hole below 4g. >>> >> >> OK, dropping this patch for now, at least from -urgent. >> >> We really need to restrict the memory types we map, at least without >> ioremap() called on them. In theory, on x86-64, we could have a >> dedicated "1:1" address for each physical address, but there is no good >> reason we should ever map memory types other than RAM, ACPI and EFI by >> default -- with the possible exception of the low 1 MiB legacy area. > > please check attach patch for tip/efi branch. That doesn't do anything like what I noted above. We should get rid of dependencies on legacy PC memory layouts, not add more hacks. What is so hard about "when we create the initial mappings, only create for RAM/ACPI/EFI regions" (if we even need to do so for ACPI, I think ACPI might use ioremap() already)? -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/