Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753899Ab2BXF4o (ORCPT ); Fri, 24 Feb 2012 00:56:44 -0500 Received: from eu1sys200aog112.obsmtp.com ([207.126.144.133]:54231 "EHLO eu1sys200aog112.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979Ab2BXF4n (ORCPT ); Fri, 24 Feb 2012 00:56:43 -0500 From: Linus Walleij To: , Cc: Stephen Warren , Grant Likely , Barry Song <21cnbao@gmail.com>, Shawn Guo , Thomas Abraham , Dong Aisheng , Rajendra Nayak , Haojian Zhuang , Linus Walleij Subject: [PATCH] pinctrl: make the pinmux-pins more helpful Date: Fri, 24 Feb 2012 06:56:09 +0100 Message-ID: <1330062969-25016-1-git-send-email-linus.walleij@stericsson.com> X-Mailer: git-send-email 1.7.8 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1901 Lines: 58 From: Linus Walleij The debugfs file pinmux-pins used to tell which function was enabled but now states simply which device owns the pin. Being owned by the pinctrl driver itself means just that it's hogged so be a bit more helpful by printing that. Signed-off-by: Linus Walleij --- I somewhat mourn the loss of being able to tell from the debugfs which function is using a certain pin, does anyone have ideas on how to go about fixing this properly? The root file pinctrl-handles does tell it, but requires cross-referencing which isn't helpful. --- drivers/pinctrl/pinmux.c | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c index 98b89d6..db5ed86 100644 --- a/drivers/pinctrl/pinmux.c +++ b/drivers/pinctrl/pinmux.c @@ -626,8 +626,8 @@ static int pinmux_pins_show(struct seq_file *s, void *what) /* The pin number can be retrived from the pin controller descriptor */ for (i = 0; i < pctldev->desc->npins; i++) { - struct pin_desc *desc; + const char *owner; pin = pctldev->desc->pins[i].number; desc = pin_desc_get(pctldev, pin); @@ -635,9 +635,16 @@ static int pinmux_pins_show(struct seq_file *s, void *what) if (desc == NULL) continue; + if (!desc->owner) + owner = "UNCLAIMED"; + else if (!strcmp(desc->owner, pinctrl_dev_get_name(pctldev))) + owner = "HOG"; + else + owner = desc->owner; + seq_printf(s, "pin %d (%s): %s\n", pin, desc->name ? desc->name : "unnamed", - desc->owner ? desc->owner : "UNCLAIMED"); + owner); } return 0; -- 1.7.8 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/