Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757589Ab2BXPwB (ORCPT ); Fri, 24 Feb 2012 10:52:01 -0500 Received: from mail.openrapids.net ([64.15.138.104]:42573 "EHLO blackscsi.openrapids.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754567Ab2BXPv6 (ORCPT ); Fri, 24 Feb 2012 10:51:58 -0500 Date: Fri, 24 Feb 2012 10:51:55 -0500 From: Mathieu Desnoyers To: Ingo Molnar Cc: Jason Baron , Linus Torvalds , Paul Mackerras , "H. Peter Anvin" , Steven Rostedt , a.p.zijlstra@chello.nl, davem@davemloft.net, ddaney.cavm@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/10] jump label: introduce very_[un]likely + cleanups + docs Message-ID: <20120224155155.GA19381@Krystal> References: <7479958c-1932-4ced-a7a4-53ac6ea3a38e@email.android.com> <20120222081855.GB25318@elte.hu> <20120222213343.GA19758@bloggs.ozlabs.ibm.com> <20120223100205.GD24310@elte.hu> <20120223223348.GA25513@elte.hu> <20120223223933.GA7942@elte.hu> <20120223231842.GA31030@Krystal> <20120224022512.GA3777@redhat.com> <20120224090811.GB814@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120224090811.GB814@elte.hu> X-Editor: vi X-Info: http://www.efficios.com X-Operating-System: Linux/2.6.26-2-686 (i686) X-Uptime: 10:50:25 up 457 days, 20:53, 5 users, load average: 0.16, 0.10, 0.03 User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1281 Lines: 42 * Ingo Molnar (mingo@elte.hu) wrote: [...] > > [...] so we are going to have to change either the branch site > > or the test for true/false name. The above > > 'static_key_inline_true/false' solves that. > > It's generally good practice to make the mostly commonly used > method names the simplest/shortest names - i.e. I don't think we > should make it longer via adding an _inline to every use. > > In that sense static_key_true() has pretty optimal length - we'd > like these tests to also be visually unintrusive. > > So in the latest patch (still under testing, will push it out > soon) we have: > > static_key_true() > static_key_false() > static_key_enabled() Hi Ingo, Yes, I think your proposal makes sense. The "_inline_" would add lots of typing for little clarity value. And I guess people will get used to these constructs. Acked-by: Mathieu Desnoyers Thanks, Mathieu -- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/