Message-ID: <1330104044.25686.165.camel@gandalf.stny.rr.com>
Subject: Re: Large slowdown with 'x86: Avoid invoking RCU when CPU is idle'
From: Steven Rostedt <rostedt@goodmis.org>
To: paulmck@linux.vnet.ibm.com
Cc: Josh Boyer <jwboyer@redhat.com>, linux-kernel@vger.kernel.org,
        kernel-team@fedoraproject.org
Date: Fri, 24 Feb 2012 12:20:44 -0500
In-Reply-To: <20120224165130.GB2399@linux.vnet.ibm.com>
References: <20120222011652.GE23186@zod.bos.redhat.com>
	 <20120222013252.GZ2375@linux.vnet.ibm.com>
	 <20120222014242.GF23186@zod.bos.redhat.com>
	 <20120224144032.GA13903@zod.bos.redhat.com>
	 <20120224161743.GA2399@linux.vnet.ibm.com>
	 <20120224162745.GC13903@zod.bos.redhat.com>
	 <20120224165130.GB2399@linux.vnet.ibm.com>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1433
Lines: 38

On Fri, 2012-02-24 at 08:51 -0800, Paul E. McKenney wrote:

> But after looking this over, Steven Rostedt's three-patch set should
> suffice:
> 
> 	https://lkml.org/lkml/2012/2/7/231
> 
> The reason that mine are not needed is that the problematic code is
> called -only- from idle, not from process context, and also that the
> problematic code is tracing.  My patch #45 is required for code that is
> called from both process context and from idle.  My patch #46 is required
> for non-tracing uses of RCU from within the idle loop -- along with TBD
> patches to wrap those uses of RCU in the RCU_NONIDLE() macro.
> 
> So again, in your particular case of x86's power-tracing features,
> Steven Rostedt's three-patch series called out above should be all
> that you need.
> 
> I have CCed Steven in case there is some prerequisite to his patch set.

The above link is the RFC, it probably still suffices, but the patches
that are going into mainline are here:

https://lkml.org/lkml/2012/2/13/530
https://lkml.org/lkml/2012/2/13/525
https://lkml.org/lkml/2012/2/13/524

The above is the order to apply them, (patch 3, 4, and 5) even though
they arrived to LKML out of order.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/