Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758022Ab2BXR71 (ORCPT ); Fri, 24 Feb 2012 12:59:27 -0500 Received: from mail-yx0-f174.google.com ([209.85.213.174]:42239 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755751Ab2BXR7Z convert rfc822-to-8bit (ORCPT ); Fri, 24 Feb 2012 12:59:25 -0500 MIME-Version: 1.0 In-Reply-To: <1330099282-4588-1-git-send-email-danny.kukawka@bisect.de> References: <1330099282-4588-1-git-send-email-danny.kukawka@bisect.de> From: =?ISO-8859-2?Q?Micha=B3_Miros=B3aw?= Date: Fri, 24 Feb 2012 18:59:04 +0100 Message-ID: Subject: Re: [PATCH 00/12] Part 2: check given MAC address, if invalid return -EADDRNOTAVAIL To: Danny Kukawka Cc: "David S. Miller" , Andy Gospodarek , Guo-Fu Tseng , Petko Manolov , "VMware, Inc." , "John W. Linville" , linux390@de.ibm.com, Mauro Carvalho Chehab , Danny Kukawka , Stephen Hemminger , Joe Perches , Jeff Kirsher , Jiri Pirko , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, linux-hams@vger.kernel.org, linux-mips@linux-mips.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 769 Lines: 18 2012/2/24 Danny Kukawka : > Second Part of series patches to unifiy the return value of > .ndo_set_mac_address if the given address isn't valid. > > These changes check if a given (MAC) address is valid in > .ndo_set_mac_address, if invalid return -EADDRNOTAVAIL > as eth_mac_addr() already does if is_valid_ether_addr() fails. Why not just fix dev_set_mac_address() and make do_setlink() use that? Checks are specific to address family, not device model I assume. Best Regards, Michał Mirosław -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/