Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755016Ab2BXXnw (ORCPT ); Fri, 24 Feb 2012 18:43:52 -0500 Received: from mail-pz0-f46.google.com ([209.85.210.46]:64733 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752675Ab2BXXnu (ORCPT ); Fri, 24 Feb 2012 18:43:50 -0500 Authentication-Results: mr.google.com; spf=pass (google.com: domain of gregkh@linuxfoundation.org designates 10.68.229.67 as permitted sender) smtp.mail=gregkh@linuxfoundation.org Date: Fri, 24 Feb 2012 15:39:42 -0800 From: Greg Kroah-Hartman To: Darren Hart Cc: Alan Cox , Linux Kernel Mailing List , Tomoya MORINAGA , Feng Tang , Alan Cox , linux-serial@vger.kernel.org Subject: Re: [PATCH 2/4] pch_uart: Add Fish River Island II uart clock quirks Message-ID: <20120224233942.GA16650@kroah.com> References: <26a433d1bdb5805cac69efb20d3e32dbf790339b.1329875301.git.dvhart@linux.intel.com> <4982ca7a73cfe208a2a5ff0a7e0da54b99ca2d2e.1329875301.git.dvhart@linux.intel.com> <20120222085250.193096c9@pyramind.ukuu.org.uk> <4F44B95E.3030307@linux.intel.com> <20120224215315.GC25330@kroah.com> <4F480E6B.90301@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F480E6B.90301@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1936 Lines: 51 On Fri, Feb 24, 2012 at 02:25:47PM -0800, Darren Hart wrote: > > > On 02/24/2012 01:53 PM, Greg Kroah-Hartman wrote: > > On Wed, Feb 22, 2012 at 01:46:06AM -0800, Darren Hart wrote: > >> > >> > >> On 02/22/2012 12:52 AM, Alan Cox wrote: > >>>> + /* Setup UART clock, checking for board specific clocks. */ > >>>> + uartclk = DEFAULT_UARTCLK; > >>>> + > >>>> + board_name = dmi_get_system_info(DMI_BOARD_NAME); > >>>> + if (board_name && strstr(board_name, "CM-iTC")) > >>>> + uartclk = CMITC_UARTCLK; > >>>> + > >>>> + board_name = dmi_get_system_info(DMI_PRODUCT_NAME); > >>>> + if (board_name && strstr(board_name, "Fish River Island II")) > >>>> + uartclk = FRI2_UARTCLK; > >>>> + > >>>> + port->uartclk = uartclk; > >>> > >>> This is confusing, you load product name into a variable called > >>> board_name ?? perhaps "name" would be clearer ? > >> > >> OK, done. > > > > "Done" where? Is there a newer patch series I should be looking at > > here to apply? I'm guessing I can ignore this one, right? > > > > consider it ignored :) > > I have the V2 patch series here, tested it, was going to send it today > .... then received a new revision of the hardware/firmware which hides > the PCI device and the UART is driven by the 8250 driver and requires me > to use 3318 as the baud ..... ***sigh***. I'm not sure what the right > thing is to do right now. I'm going to have a conversation with the > hardware manufacturer and the TWO firmware teams I'm working with. > > If anyone has experience with this sort of mess and would like to offer > a recommended course of action, I'm all ears. A big stick is usually best to use on the firmware engineers... Good luck, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/