Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756178Ab2BYKPY (ORCPT ); Sat, 25 Feb 2012 05:15:24 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:64161 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755900Ab2BYKPX convert rfc822-to-8bit (ORCPT ); Sat, 25 Feb 2012 05:15:23 -0500 MIME-Version: 1.0 In-Reply-To: <1330091162-8141-4-git-send-email-danny.kukawka@bisect.de> References: <1330091162-8141-1-git-send-email-danny.kukawka@bisect.de> <1330091162-8141-4-git-send-email-danny.kukawka@bisect.de> Date: Sat, 25 Feb 2012 11:15:21 +0100 X-Google-Sender-Auth: gtcO1xMxdo3c7_libwSfM1VSj1A Message-ID: Subject: Re: [PATCH 03/11] cirrus/mac89x0: print MAC via printk format specifier From: Geert Uytterhoeven To: Danny Kukawka Cc: "David S. Miller" , Danny Kukawka , Jeff Kirsher , Jiri Pirko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2293 Lines: 55 On Fri, Feb 24, 2012 at 14:45, Danny Kukawka wrote: > Print MAC/dev_addr via printk extended format specifier %pM instead > of custom code. > > Use memcpy to set the address to dev->dev_addr in set_mac_address, > instead of mxing it up in a for loop with printing a debug msg. > > Check also if the given address is valid. Why do you sneak in this check in this patch? > Signed-off-by: Danny Kukawka > --- >  drivers/net/ethernet/cirrus/mac89x0.c |   12 ++++++++---- >  1 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/cirrus/mac89x0.c b/drivers/net/ethernet/cirrus/mac89x0.c > index 83781f3..a7324ce 100644 > --- a/drivers/net/ethernet/cirrus/mac89x0.c > +++ b/drivers/net/ethernet/cirrus/mac89x0.c > @@ -592,10 +592,14 @@ static void set_multicast_list(struct net_device *dev) >  static int set_mac_address(struct net_device *dev, void *addr) >  { >        int i; > -       printk("%s: Setting MAC address to ", dev->name); > -       for (i = 0; i < 6; i++) > -               printk(" %2.2x", dev->dev_addr[i] = ((unsigned char *)addr)[i]); > -       printk(".\n"); > +       struct sockaddr *saddr = addr; > + > +       if (!is_valid_ether_addr(addr->sa_data)) > +               return -EADDRNOTAVAIL; > + > +       memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN); > +       printk("%s: Setting MAC address to %pM\n", dev->name, dev->dev_addr); > + >        /* set the Ethernet address */ >        for (i=0; i < ETH_ALEN/2; i++) >                writereg(dev, PP_IA+i*2, dev->dev_addr[i*2] | (dev->dev_addr[i*2+1] << 8)); Gr{oetje,eeting}s,                         Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.                                 -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/