Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752873Ab2BZTxW (ORCPT ); Sun, 26 Feb 2012 14:53:22 -0500 Received: from mail-gx0-f174.google.com ([209.85.161.174]:40793 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752550Ab2BZTxV convert rfc822-to-8bit (ORCPT ); Sun, 26 Feb 2012 14:53:21 -0500 MIME-Version: 1.0 In-Reply-To: References: <1330155147-15118-1-git-send-email-yinghai@kernel.org> Date: Sun, 26 Feb 2012 11:53:20 -0800 X-Google-Sender-Auth: O7STyZifjrtcUvDpkudUik5ycdc Message-ID: Subject: Re: [PATCH 1/2] PCI: Separate host_bridge code out from probe.c From: Yinghai Lu To: Bjorn Helgaas Cc: Jesse Barnes , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 626 Lines: 15 On Sat, Feb 25, 2012 at 8:17 AM, Bjorn Helgaas wrote: > On Sat, Feb 25, 2012 at 12:32 AM, Yinghai Lu wrote: >> +void add_to_pci_host_bridges(struct list_head *list) > > I'd prefer to pass a "struct pci_host_bridge *" here instead of a > "struct list_head *". ?That way the compiler can check a little more. ok, let me check it. Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/