Date: Sun, 26 Feb 2012 17:04:18 -0800 (PST)
From: Andrei Warkentin <awarkentin@vmware.com>
To: Jason Wessel <jason.wessel@windriver.com>
Cc: kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org,
        Andrei Warkentin <andreiw@vmware.com>
Message-ID: <190287371.1567191.1330304658088.JavaMail.root@zimbra-prod-mbox-2.vmware.com>
In-Reply-To: <4F4A3A8D.7030700@windriver.com>
Subject: Re: [PATCH] KDB: Fix usability issues relating to the 'enter' key.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1200
Lines: 29

Hi,

----- Original Message -----
> From: "Jason Wessel" <jason.wessel@windriver.com>
> To: "Andrei Warkentin" <andreiw@vmware.com>
> Cc: kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org
> Sent: Sunday, February 26, 2012 8:58:37 AM
> Subject: Re: [PATCH] KDB: Fix usability issues relating to the 'enter' key.

> 
> Andrei, if you agree with the attached patch, I'll put it in the
> merge queue.  If you find problems we can go another iteration. :-)
>

Nak. As I've mentioned in my original email, I went down this route as well, only
to ask the question of why the special ENTER code was there, since all it did
was introduce problems elsewhere (like repeat ENTER handling, KP ENTER key...).
This is exactly why my solution was to get rid of the special ENTER code altogether.

The code in kgdboc already will do input device reset on kdb exit, so there is no need
to explicitely empty out the keyboard FIFO on every ENTER.

Thanks,
A
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/