Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753357Ab2B0NyY (ORCPT ); Mon, 27 Feb 2012 08:54:24 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:36192 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753135Ab2B0NyW convert rfc822-to-8bit (ORCPT ); Mon, 27 Feb 2012 08:54:22 -0500 Authentication-Results: mr.google.com; spf=pass (google.com: domain of linus.walleij@linaro.org designates 10.42.18.195 as permitted sender) smtp.mail=linus.walleij@linaro.org MIME-Version: 1.0 In-Reply-To: <20120227110204.GA30199@n2100.arm.linux.org.uk> References: <20120227104858.GR22562@n2100.arm.linux.org.uk> <20120227110204.GA30199@n2100.arm.linux.org.uk> Date: Mon, 27 Feb 2012 14:54:22 +0100 Message-ID: Subject: Re: [PATCH] Clear previous interrupts after fifo is disabled From: Linus Walleij To: Russell King - ARM Linux Cc: Chanho Min , Alan Cox , Greg Kroah-Hartman , Shreshtha Kumar Sahu , "Kim, Jong-Sung" , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 769 Lines: 20 On Mon, Feb 27, 2012 at 12:02 PM, Russell King - ARM Linux wrote: > On Mon, Feb 27, 2012 at 10:48:58AM +0000, Russell King - ARM Linux wrote: >> I'd much prefer to only clear those interrupts which actually need to be >> cleared at this point. ?So, I'd suggest this approach instead: > > Thinking about this a little more, we definitely want to mask and clear > interrupts at probe time as well: Acked-by: Linus Walleij On the RMK-improved patch. Thanks, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/