Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753460Ab2B0PpU (ORCPT ); Mon, 27 Feb 2012 10:45:20 -0500 Received: from mail16.primus.ca ([216.254.141.183]:49442 "EHLO mail-05.primus.ca" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752825Ab2B0PpS (ORCPT ); Mon, 27 Feb 2012 10:45:18 -0500 X-Greylist: delayed 1855 seconds by postgrey-1.27 at vger.kernel.org; Mon, 27 Feb 2012 10:45:18 EST Message-ID: <4F4B9DD2.6000600@bell.net> Date: Mon, 27 Feb 2012 10:14:26 -0500 From: John David Anglin User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: Paul Gortmaker CC: JBottomley@parallels.com, jejb@parisc-linux.org, kyle@mcmartin.ca, deller@gmx.de, linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org Subject: Re: [PATCH] parisc: dont unconditionally override CROSS_COMPILE for 64 bit. References: <1330298813-17262-1-git-send-email-paul.gortmaker@windriver.com> In-Reply-To: <1330298813-17262-1-git-send-email-paul.gortmaker@windriver.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated: danglin-lux@magma.ca - 216-58-40-249.cpe.distributel.net ([192.168.0.181]) [216.58.40.249] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1806 Lines: 52 On 2/26/2012 6:26 PM, Paul Gortmaker wrote: > Using the 64 bit toolchains from kernel.org[1], one finds that > you can't build the a500_defconfig, because the Makefile will > stomp whatever value you have in your env. for CROSS_COMPILE. > > This shows up since the kernel.org toolchains for parisc-64 > do not have the "-gnu" prefix, and so you run into it always > saying hppa64-linux-gnu-gcc not found, regardless of the fact > you've not got "-gnu" put anywhere into CROSS_COMPILE. > > [1] ftp://ftp.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.5.2/ > > Signed-off-by: Paul Gortmaker > > diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile > index 55cca1d..cefff6d 100644 > --- a/arch/parisc/Makefile > +++ b/arch/parisc/Makefile > @@ -31,7 +31,9 @@ ifdef CONFIG_64BIT > UTS_MACHINE := parisc64 > CHECKFLAGS += -D__LP64__=1 -m64 > WIDTH := 64 > -CROSS_COMPILE := hppa64-linux-gnu- > +ifndef CROSS_COMPILE > + CROSS_COMPILE := hppa64-linux-gnu- > +endif > else # 32-bit > WIDTH := > endif This change breaks native builds. So, I assume CROSS_COMPILE must be previously defined. I couldn't figure out where it is defined. CONFIG_CROSS_COMPILE in my .config was an empty string and CROSS_COMPILE was not defined in my build environment. The default toolchain prefix on Debian systems contains "gnu-". Given that users can use CONFIG_CROSS_COMPILE or set CROSS_COMPILE in their build env, maybe setting CROSS_COMPILE in the Makefile is a mistake. Dave -- John David Anglin dave.anglin@bell.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/