Message-ID: <1330363627.9942.16.camel@joe2Laptop>
Subject: Re: "whitespace coding style cleanup" broke coding style
From: Joe Perches <joe@perches.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Jiri Slaby <jirislaby@gmail.com>, LKML <linux-kernel@vger.kernel.org>,
        Hansjoerg Lipp <hjlipp@web.de>, Tilman Schmidt <tilman@imap.cc>,
        gigaset307x-common@lists.sourceforge.net
Date: Mon, 27 Feb 2012 09:27:07 -0800
In-Reply-To: <4F4BB983.8020608@suse.cz>
References: <4F4B45F6.4090706@suse.cz> <1330361549.9942.7.camel@joe2Laptop>
	 <4F4BB983.8020608@suse.cz>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1902
Lines: 57

On Mon, 2012-02-27 at 18:12 +0100, Jiri Slaby wrote:
> On 02/27/2012 05:52 PM, Joe Perches wrote:
> > Notice that the code improperly uses commas and
> > not semicolons for line terminations like the
> > lines immediately above and below it.
> 
> Oh, and you see that you made it actually _worse_?

Actually, no.  This changes does highlight a
nominal code style defect though.

> The patch should not 
> touch the code at all. It is obviously totally broken. In a separate 
> patch you might do s@,@;@ instead.

The code in either form is neither broken nor
incorrect.  It's just "out of style".
Emacs did made it consistent.

> Hmm, but did not we conclude some time ago that we will not touch code 
> just to perform a whitespace cleanup?

It's a prelude to other patches so actually
that's done quite a lot.   git blame -w
doesn't even show my name on any of the
code in this patch.

> > It was a first pass and an overall improvement.
> 
> I hope no other passes are going to happen there or anywhere in TTY 
> drivers. I really do not want to solve zillion collisions in my ~100 
> local patches due to whitespace changes, sorry.

Perhaps you should submit your ~100 patches sooner
rather than later.  That's a lot of changes that
could have any number of collisions.

> Yes, but it does not pass our brain, does it? One should throw 
> "checkpatch --file" or alike away, finally.

Perhaps you might notice I did not use checkpatch
as a guide nor as a criteria for submission.

It was ~5MB patch btw.  Compilation was done to
verify lack of object delta only.

Thanks for noticing the oddly formatted code.
I'll send a patch to fix it.

cheers, Joe


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/