Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754493Ab2B0Tkr (ORCPT ); Mon, 27 Feb 2012 14:40:47 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:50618 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738Ab2B0Tkq (ORCPT ); Mon, 27 Feb 2012 14:40:46 -0500 Date: Mon, 27 Feb 2012 20:40:38 +0100 From: Ingo Molnar To: Namhyung Kim Cc: Peter Zijlstra , Namhyung Kim , Paul Mackerras , Arnaldo Carvalho de Melo , LKML , Frederic Weisbecker Subject: Re: [PATCH] hw breakpoint: Fix possible memory leak Message-ID: <20120227194038.GA11448@elte.hu> References: <1330311739-24302-1-git-send-email-namhyung.kim@lge.com> <1330338785.11248.49.camel@twins> <20120227104452.GA6082@elte.hu> <1330340694.11248.64.camel@twins> <20120227115652.GA9943@elte.hu> <1330349551.1782.15.camel@leonhard> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1330349551.1782.15.camel@leonhard> User-Agent: Mutt/1.5.21 (2010-09-15) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2169 Lines: 64 * Namhyung Kim wrote: > 2012-02-27 (월), 12:56 +0100, Ingo Molnar: > > * Peter Zijlstra wrote: > > > > > On Mon, 2012-02-27 at 11:44 +0100, Ingo Molnar wrote: > > > > I edited that code earlier today - is the form below OK, or can > > > > you see a simpler method? It's not yet pushed out so can still > > > > edit it. > > > > > > I think something like the below should do, but then I didn't really > > > think much about it, my thoughts went like: > > > > > > ... *shees* that's ugly > > > ... that error path already does a loop > > > ... what the problem is!? -- reread changelog > > > ... err_cpu == cpu is placed wrong! > > > > > > > > > So I replied and marked read.. waiting to either hear if there's a good > > > reason to do ugly or find a new (tested) patch in my inbox.. :-) > > > > > > --- > > > kernel/events/hw_breakpoint.c | 4 ++-- > > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c > > > index b0309f7..3330022 100644 > > > --- a/kernel/events/hw_breakpoint.c > > > +++ b/kernel/events/hw_breakpoint.c > > > @@ -658,10 +658,10 @@ int __init init_hw_breakpoint(void) > > > > > > err_alloc: > > > for_each_possible_cpu(err_cpu) { > > > - if (err_cpu == cpu) > > > - break; > > > for (i = 0; i < TYPE_MAX; i++) > > > kfree(per_cpu(nr_task_bp_pinned[i], cpu)); > > > + if (err_cpu == cpu) > > > + break; > > > } > > > > Looks a lot nicer - I'll wait for an updated patch. > > > > Thanks, > > > > Ingo > > Ingo, do you want me to resend? If so, I really don't know how > to give the credit to Peter in this case. Just mention it in the changelog that this solution was his idea. It was you who did most of the work: found the bug, wrote the patch, wrote the changelog and tested the final patch ;-) Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/