Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754116Ab2B0UOV (ORCPT ); Mon, 27 Feb 2012 15:14:21 -0500 Received: from hqemgate04.nvidia.com ([216.228.121.35]:18694 "EHLO hqemgate04.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753197Ab2B0UOU convert rfc822-to-8bit (ORCPT ); Mon, 27 Feb 2012 15:14:20 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Mon, 27 Feb 2012 12:14:05 -0800 From: Stephen Warren To: Russell King - ARM Linux CC: Paul Gortmaker , Nicolas Pitre , Stephen Boyd , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Date: Mon, 27 Feb 2012 12:14:01 -0800 Subject: RE: [PATCH] ARM: boot/compressed/misc.s: Include to fix build break Thread-Topic: [PATCH] ARM: boot/compressed/misc.s: Include to fix build break Thread-Index: Acz1ifFCBvsasGgjRQ26NPTFDaB20QAAf1IQ Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF17BD8BD04C@HQMAIL01.nvidia.com> References: <1330372350-6432-1-git-send-email-swarren@nvidia.com> <20120227195637.GE2440@n2100.arm.linux.org.uk> In-Reply-To: <20120227195637.GE2440@n2100.arm.linux.org.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1421 Lines: 32 Russell King wrote at Monday, February 27, 2012 12:57 PM: > On Mon, Feb 27, 2012 at 12:52:30PM -0700, Stephen Warren wrote: > > Commmit cf86c17 "kernel.h: doesn't explicitly use bug.h, so don't include > > it." caused the following build failure on ARM: > > > > CC arch/arm/boot/compressed/misc.o > > In file included from arch/arm/boot/compressed/misc.c:28:0: > > arch/arm/mach-tegra/include/mach/uncompress.h: In function 'arch_decomp_setup': > > arch/arm/mach-tegra/include/mach/uncompress.h:125:2: error: implicit declaration of function > 'BUILD_BUG_ON_ZERO' [-Werror=implicit-function-declaration] > > cc1: some warnings being treated as errors > > Err no. The decompressor is _not_ part of the kernel, it's a separate > stand alone environment. Including randomly kernel headers from the > rest of the kernel is bad news, particularly if they start calling out > to external code. > > You should try to keep your uncompress.h as free of other dependencies > as possible. OK, It looks like all we need from is BIT() and ARRAY_SIZE(). The latter requires . Should I just redefine those macros in our uncompress.h? -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/