Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755310Ab2B0WeZ (ORCPT ); Mon, 27 Feb 2012 17:34:25 -0500 Received: from lulu.zabbo.net ([69.168.54.52]:37019 "EHLO lulu.zabbo.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751268Ab2B0WeY (ORCPT ); Mon, 27 Feb 2012 17:34:24 -0500 Message-ID: <4F4C04EE.7080306@zabbo.net> Date: Mon, 27 Feb 2012 17:34:22 -0500 From: Zach Brown User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 MIME-Version: 1.0 To: Dave Kleikamp CC: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , Andrew Morton , Andreas Dilger , linux-ext4@vger.kernel.org Subject: Re: [RFC PATCH 18/22] ext3: add support for .read_iter and .write_iter References: <1330377576-3659-1-git-send-email-dave.kleikamp@oracle.com> <1330377576-3659-19-git-send-email-dave.kleikamp@oracle.com> In-Reply-To: <1330377576-3659-19-git-send-email-dave.kleikamp@oracle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 933 Lines: 25 > drivers/block/loop.c | 55 ++++++++++++++++++- > fs/ext3/file.c | 2 + > fs/ext3/inode.c | 149 ++++++++++++++++++++++++++++++++++---------------- > include/linux/loop.h | 1 + > 4 files changed, 160 insertions(+), 47 deletions(-) It looks like the patch that teaches loop to use the kernel aio interface got combined with the patch that adds the _bvec entry points to ext3. > + if (file->f_op->write_iter&& file->f_op->read_iter) { > + file->f_flags |= O_DIRECT; > + lo_flags |= LO_FLAGS_USE_AIO; > + } This manual setting of f_flags still looks very fishy to me. I remember finding that pattern somewhere else but that's not very comforting :). - z -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/