Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965438Ab2B1BZN (ORCPT ); Mon, 27 Feb 2012 20:25:13 -0500 Received: from mms3.broadcom.com ([216.31.210.19]:3091 "EHLO MMS3.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965212Ab2B1BZH (ORCPT ); Mon, 27 Feb 2012 20:25:07 -0500 X-Server-Uuid: B55A25B1-5D7D-41F8-BC53-C57E7AD3C201 Date: Mon, 27 Feb 2012 17:24:08 -0800 From: "Matt Carlson" To: "James Bottomley" cc: "Rafael J. Wysocki" , "Linux Kernel Mailing List" , "Kernel Testers List" , "Maciej Rutecki" , "Florian Mickler" , "Matt Carlson" , "Michael Chan" , "Ben Hutchings" , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [Bug #42707] Hang deconfiguring network interface (in shutdown) on 3.3-rc1 Message-ID: <20120228012408.GA29622@mcarlson.broadcom.com> References: <1330386274.2822.105.camel@dabdike.int.hansenpartnership.com> MIME-Version: 1.0 In-Reply-To: <1330386274.2822.105.camel@dabdike.int.hansenpartnership.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-WSS-ID: 6352F17450427975101-01-01 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1706 Lines: 42 On Mon, Feb 27, 2012 at 05:44:34PM -0600, James Bottomley wrote: > On Thu, 2012-02-23 at 23:55 +0100, Rafael J. Wysocki wrote: > > This message has been generated automatically as a part of a summary report > > of recent regressions. > > > > The following bug entry is on the current list of known regressions > > from 3.2. Please verify if it still should be listed and let the tracking team > > know (either way). > > > > > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=42707 > > Subject : Hang deconfiguring network interface (in shutdown) on 3.3-rc1 > > Submitter : James Bottomley > > Date : 2012-01-28 19:56 (27 days old) > > Message-ID : <1327780565.2924.24.camel@dabdike.int.hansenpartnership.com> > > References : http://marc.info/?l=linux-kernel&m=132778076214873&w=2 > > Still present in 3.3-rc4; I've bisected it back to this commit: > > commit 92feeabf3f673767c6ee4cfc7fc224098446c1c1 > Author: Matt Carlson > Date: Thu Dec 8 14:40:14 2011 +0000 > > tg3: Save stats across chip resets > > and sure enough, just reverting this single commit on 3.3-rc4 fixes the > problem. > > James I don't see anything incorrect about the patch. I'm guessing the patch just changes the timing somehow. tg3_reset_chip() does not take any driver-internal spinlocks. That happens at tg3_close(). I'm guessing the spinlock in the trace is coming from synchronize_irq(). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/