Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752440Ab2B1FIi (ORCPT ); Tue, 28 Feb 2012 00:08:38 -0500 Received: from na3sys009aog117.obsmtp.com ([74.125.149.242]:42450 "HELO na3sys009aog117.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751397Ab2B1FIg convert rfc822-to-8bit (ORCPT ); Tue, 28 Feb 2012 00:08:36 -0500 Authentication-Results: mr.google.com; spf=pass (google.com: domain of tarun.kanti@ti.com designates 10.229.75.143 as permitted sender) smtp.mail=tarun.kanti@ti.com MIME-Version: 1.0 In-Reply-To: <87aa43vnsv.fsf@ti.com> References: <1329999031-6914-1-git-send-email-tarun.kanti@ti.com> <1329999031-6914-3-git-send-email-tarun.kanti@ti.com> <87aa43vnsv.fsf@ti.com> Date: Tue, 28 Feb 2012 10:38:35 +0530 Message-ID: Subject: Re: [PATCH 2/6] gpio/omap: remove saved_wakeup field from struct gpio_bank From: "DebBarma, Tarun Kanti" To: Kevin Hilman Cc: linux-omap@vger.kernel.org, grant.likely@secretlab.ca, tony@atomide.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1789 Lines: 51 On Tue, Feb 28, 2012 at 5:20 AM, Kevin Hilman wrote: > Tarun Kanti DebBarma writes: > >> There is no more need to have saved_wakeup. Instead we can use >> context.wake_en which holds the current wakeup enable register >> context. This also means that the read from wakeup enable register >> is not needed. >> >> Signed-off-by: Tarun Kanti DebBarma > > Looks right, but one question below... > >> --- >> ?drivers/gpio/gpio-omap.c | ? 13 ++++--------- >> ?1 files changed, 4 insertions(+), 9 deletions(-) >> >> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c >> index 40a1fb2..64f15d5 100644 >> --- a/drivers/gpio/gpio-omap.c >> +++ b/drivers/gpio/gpio-omap.c >> @@ -54,7 +54,6 @@ struct gpio_bank { >> ? ? ? u16 irq; >> ? ? ? u16 virtual_irq_start; >> ? ? ? u32 suspend_wakeup; >> - ? ? u32 saved_wakeup; >> ? ? ? u32 non_wakeup_gpios; >> ? ? ? u32 enabled_non_wakeup_gpios; >> ? ? ? struct gpio_regs context; >> @@ -772,7 +771,7 @@ static int omap_mpuio_suspend_noirq(struct device *dev) >> ? ? ? unsigned long ? ? ? ? ? flags; >> >> ? ? ? spin_lock_irqsave(&bank->lock, flags); >> - ? ? bank->saved_wakeup = __raw_readl(mask_reg); >> + ? ? bank->context.wake_en = __raw_readl(mask_reg); > > Why is this read needed? Well, we don't really need as we already have context.wake_en updated elsewhere. I will update this. Thanks. -- Tarun > > Kevin > >> ? ? ? __raw_writel(0xffff & ~bank->suspend_wakeup, mask_reg); >> ? ? ? spin_unlock_irqrestore(&bank->lock, flags); >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/