Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932586Ab2B1N2v (ORCPT ); Tue, 28 Feb 2012 08:28:51 -0500 Received: from rcsinet15.oracle.com ([148.87.113.117]:19319 "EHLO rcsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932400Ab2B1N2u (ORCPT ); Tue, 28 Feb 2012 08:28:50 -0500 Date: Tue, 28 Feb 2012 16:30:38 +0300 From: Dan Carpenter To: Dmitry Antipov Cc: Rusty Russell , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linaro-dev@lists.linaro.org, patches@linaro.org Subject: Re: [PATCH 1/2] vmalloc: use ZERO_SIZE_PTR / ZERO_OR_NULL_PTR Message-ID: <20120228133037.GG2817@mwanda> References: <1330421640-5137-1-git-send-email-dmitry.antipov@linaro.org> <20120228094415.GA2868@mwanda> <4F4CC19D.9040608@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bpVaumkpfGNUagdU" Content-Disposition: inline In-Reply-To: <4F4CC19D.9040608@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-CT-RefId: str=0001.0A090206.4F4CD68B.00F3,ss=1,re=0.000,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2124 Lines: 57 --bpVaumkpfGNUagdU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 28, 2012 at 03:59:25PM +0400, Dmitry Antipov wrote: > On 02/28/2012 01:44 PM, Dan Carpenter wrote: > >On Tue, Feb 28, 2012 at 01:33:59PM +0400, Dmitry Antipov wrote: > >> - Fix vmap() to return ZERO_SIZE_PTR if 0 pages are requested; > >> - fix __vmalloc_node_range() to return ZERO_SIZE_PTR if 0 bytes > >> are requested; > >> - fix __vunmap() to check passed pointer with ZERO_OR_NULL_PTR. > >> > > > >Why? >=20 > 1) it was requested by the subsystem (co?)maintainer, see http://lkml.org= /lkml/2012/1/27/475; > 2) this looks to be a convenient way to trace/debug zero-size allocation = errors (although > I don't advocate it as a best way). Could you include that in the changelog when the final version is ready? regards, dan carpenter --bpVaumkpfGNUagdU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJPTNb9AAoJEOnZkXI/YHqRrqcP/jaoljPhqho4mWZ4LW0hUsec 8t25uxiUsI/POB5AgBC250hQCLSQrLWJM/piQhKdV6cIMOtccBaiQdoUHVGVKpmT xe7EopnUnwn9OC45sY7iwGmLJ1BCw+1PJ4bpfFfJuxXs2+rMbToeR4sfiWt/T19d VA7N3sORxDCRgGT77VpCW+XG8xguvObQ4WhBtHOKxVfANxYlOwvC54vxzfpF1txo //RwLAXAC4hADMaeQHuneIT5NnI68t2O4QYjBb3OZI5q/uvyBe/dOnKdJZqgSPxz v6f0TCLY/Pueg/0+e0/ZB/4zUyIWOmt0oU8nAThZvdUYUtpGwjT8AZRoX8I7nJaP KOjWqsy1Z1FYnP7OnDMXkmQoPJqsR1gmtfhTXpdB5i/UZ6ofClnTuxsZ+/epAr1X S7fwIxCXGJuIfwxwb3+Y87dCzpV2KDjKvMPdlP6xwJ2KdHfB1MkuJAf4yCJfvFFf mBIPmnToOJmZJJLMzqHvRwhDX/bQSnAeFTVcEbCcaDnh3ERPqutqFeR5ugDth99r 54SYTX6+iLAQg6fIOP34RzIrZ0bNlvV8V2DQxzZRTik0HjLK27eYQGeZMiMvkZMW 6H9W0aCM7LfEdayERkjlR0IVQeVHI25+/JHPyk8YshZE5FFLELP5k1JMErsSh037 DPmjyPhdmL5LytWbA5HX =b7tR -----END PGP SIGNATURE----- --bpVaumkpfGNUagdU-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/