Message-ID: <4F4CEF5A.1020207@zabbo.net>
Date: Tue, 28 Feb 2012 10:14:34 -0500
From: Zach Brown <zab@zabbo.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0
MIME-Version: 1.0
To: Christoph Hellwig <hch@infradead.org>
CC: Dave Kleikamp <dave.kleikamp@oracle.com>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 00/22] loop: Issue O_DIRECT aio with pages
References: <1330377576-3659-1-git-send-email-dave.kleikamp@oracle.com> <20120228092926.GA2766@infradead.org>
In-Reply-To: <20120228092926.GA2766@infradead.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 983
Lines: 23


> For one you make ->aio_read/write trivial wrappers around ->read_iter
> and ->write_iter.  Instead of keeping this duplication around please
> make sure to entirely kill ->aio_read/write and always use your new
> methods.  Without that we'll get into a complete mess like the old
> ->aio_read/write vs ->readv/writev again.
>
> A similar thing applies to the ->direct_IO/direct_IO_bvec interface -

Yeah, that's reasonable.  Perhaps obviously, we started with new entry
points to minimize the amount of churn we'd have to go through to test
the change in behaviour.

It's going to be messy to try and abstract away the pinning and dirtying
of the iter regions from direct IO through the iter interface, but maybe
not horribly so.

- z
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/