Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752577Ab2B2F3K (ORCPT ); Wed, 29 Feb 2012 00:29:10 -0500 Received: from mail-pz0-f52.google.com ([209.85.210.52]:38674 "EHLO mail-pz0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751391Ab2B2F3I (ORCPT ); Wed, 29 Feb 2012 00:29:08 -0500 Authentication-Results: mr.google.com; spf=pass (google.com: domain of hughd@google.com designates 10.68.129.4 as permitted sender) smtp.mail=hughd@google.com; dkim=pass header.i=hughd@google.com Date: Tue, 28 Feb 2012 21:28:40 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Andrew Morton cc: KAMEZAWA Hiroyuki , Johannes Weiner , Konstantin Khlebnikov , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH next] memcg: remove PCG_FILE_MAPPED fix cosmetic fix In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (LSU 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1030 Lines: 26 mem_cgroup_move_account() begins with "anon = PageAnon(page)", and then anon is used thereafter: testing PageAnon(page) in the middle makes the reader wonder if there's some race to guard against - no. Signed-off-by: Hugh Dickins --- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- 3.3-rc5-next/mm/memcontrol.c 2012-02-27 09:56:59.072001463 -0800 +++ linux/mm/memcontrol.c 2012-02-28 20:45:43.488100423 -0800 @@ -2560,7 +2560,7 @@ static int mem_cgroup_move_account(struc move_lock_mem_cgroup(from, &flags); - if (!PageAnon(page) && page_mapped(page)) { + if (!anon && page_mapped(page)) { /* Update mapped_file data for mem_cgroup */ preempt_disable(); __this_cpu_dec(from->stat->count[MEM_CGROUP_STAT_FILE_MAPPED]); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/