Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030839Ab2B2HaX (ORCPT ); Wed, 29 Feb 2012 02:30:23 -0500 Received: from wolverine01.qualcomm.com ([199.106.114.254]:24753 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030751Ab2B2HaV convert rfc822-to-8bit (ORCPT ); Wed, 29 Feb 2012 02:30:21 -0500 X-IronPort-AV: E=McAfee;i="5400,1158,6634"; a="167394314" X-IronPort-AV: E=Sophos;i="4.73,499,1325491200"; d="scan'208";a="173294464" From: "Huang, Xiong" To: David Miller CC: "Rodriguez, Luis" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , qca-linux-team , nic-devel , "Giori, Kathy" , "chris.snook@gmail.com" Subject: RE: [PATCH] net: add QCA alx Ethernet driver Thread-Topic: [PATCH] net: add QCA alx Ethernet driver Thread-Index: AQHM9oR7kTu/A5Gy+kqKXc430uKtxJZTowaAgAAFPID//3p5IIAAih6A//+DQTCAAI6iAP//u26w Date: Wed, 29 Feb 2012 07:30:20 +0000 Message-ID: <157393863283F442885425D2C454285619415703@nasanexd02a.na.qualcomm.com> References: <157393863283F442885425D2C4542856194154FC@nasanexd02a.na.qualcomm.com> <20120228.212857.797446903975232476.davem@davemloft.net> <157393863283F442885425D2C454285619415561@nasanexd02a.na.qualcomm.com> <20120228.223258.2261979237568571219.davem@davemloft.net> In-Reply-To: <20120228.223258.2261979237568571219.davem@davemloft.net> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.45.230.6] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1733 Lines: 39 My another concern is the license type. Current atl1c use GPL v2, and got some contribution outside of QCA though the first version was wrote by our Atheros guy. And that guy just copied the license from atl1e/atl1x that contains the words "Derived from Intel e1000". If I update this driver and add new chip support on it, Our Company's legal might not permit me to do so, they prefer QCA ISC license. Is it possible to change the license header to ISC while I applying patches to source code ? Thanks xiong > -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > Sent: Wednesday, February 29, 2012 11:33 > To: Huang, Xiong > Cc: Rodriguez, Luis; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; > qca-linux-team; nic-devel; Giori, Kathy; chris.snook@gmail.com; Olivari, > Mathieu; Huntsman, Bryan > Subject: Re: [PATCH] net: add QCA alx Ethernet driver > > From: "Huang, Xiong" > Date: Wed, 29 Feb 2012 03:11:14 +0000 > > > We understand your concern. To support the new chipset, do you think > > it's reasonable to upstream it as a new driver, not a replacement ? > > It depends upon how similar the chips are. > > To be honest tg3, as one example, supports quite a large array of different > pieces of hardware that use the same logical core. > > So that would be my litmus test about how different a chip needs to be to > deserve an entirely new driver. > > I strongly suggest you try to get atl1c working properly. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/