Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932579Ab2B2MpR (ORCPT ); Wed, 29 Feb 2012 07:45:17 -0500 Received: from nbd.name ([46.4.11.11]:36894 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754024Ab2B2MpP (ORCPT ); Wed, 29 Feb 2012 07:45:15 -0500 Message-ID: <4F4E1DD7.4050509@openwrt.org> Date: Wed, 29 Feb 2012 13:45:11 +0100 From: Felix Fietkau User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: YIN Wei CC: johannes , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, mattias.nissler@gmx.de, stefano.brivio@polimi.it Subject: Re: [PATCH] mac80211: improve PID rate control mechanism by avoiding rate oscillation problem References: In-Reply-To: X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1831 Lines: 40 On 2012-02-29 1:14 PM, YIN Wei wrote: > From: Wei YIN (Wei.Yin@nicta.com.au) > > Improve PID rate control mechanism by solving the rate oscillation > problem. Current PID mechanism is based on a PID controller which > tries to minimise the difference between the frame loss ratio (FLR) > and the target FLR. Therefore it is straight forward that it increases > to a higher rate when the FLR is less than the target without > considering whether the higher rate can be supported. If the higher > rate cannot be supported, significant FLR will occur, which causes the > mechanism to decrease the rate sharply. The proposed approach only > updates the rate when the proposed rate by the PID controller can > achieve better throughput than the old rate. This patch applies to > kernel 3.3.0. > Signed-off-by: Wei YIN (Wei.Yin@nicta.com.au) > --- > diff -uprN wireless-testing_orig/net/mac80211/Kconfig > wireless-testing/net/mac80211/Kconfig > --- wireless-testing_orig/net/mac80211/Kconfig 2012-02-17 > 13:59:53.495254495 +1000 > +++ wireless-testing/net/mac80211/Kconfig 2012-02-21 11:35:40.495706869 +1000 > @@ -21,6 +21,7 @@ config MAC80211_HAS_RC > config MAC80211_RC_PID > bool "PID controller based rate control algorithm" if EXPERT > select MAC80211_HAS_RC > + default y > ---help--- > This option enables a TX rate control algorithm for > mac80211 that uses a PID controller to select the TX Several issues with this patch: line wrapping, weird encoding in the comments: — Also, please drop this change that alters the default value of MAC80211_RC_PID. - Felix -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/