Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932754Ab2B2QIu (ORCPT ); Wed, 29 Feb 2012 11:08:50 -0500 Received: from wp188.webpack.hosteurope.de ([80.237.132.195]:51570 "EHLO wp188.webpack.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932730Ab2B2QIh (ORCPT ); Wed, 29 Feb 2012 11:08:37 -0500 From: Danny Kukawka To: "David S. Miller" Cc: Danny Kukawka , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 0/8] validate MAC address before call .ndo_set_mac_address Date: Wed, 29 Feb 2012 17:08:12 +0100 Message-Id: <1330530176-24952-1-git-send-email-danny.kukawka@bisect.de> X-Mailer: git-send-email 1.7.8.3 X-bounce-key: webpack.hosteurope.de;danny.kukawka@bisect.de;1330531717;ab1f0c1a; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2423 Lines: 55 Validate the given MAC address directly in dev_set_mac_address() if a .ndo_validate_addr function is available before calling the .ndo_set_mac_address function. Changed .ndo_validate_addr to take a second parameter containing a sockaddr struct to be checked instead of the net_device dev_addr. The behaviour of .ndo_validate_addr is now: if the second parameter is NULL the net_device->dev_addr gets validate, if != NULL the given parameter/sockaddr gets validated instead. This patch series include adaptations for some drivers which use .ndo_set_mac_address functions directly - to prevent double checks and to enable validations via .ndo_validate_addr. If these patches get accepted, an other series will follow to cleanup the validation checks in the .ndo_set_mac_address functions. Note: resend for ML's Danny Kukawka (8): net: validate MAC address directly in dev_set_mac_address() bnx2x: adopt bnx2x_validate_addr() to .ndo_validate_addr changes cris/eth_v10: use dev_set_mac_address() instead of e100_set_mac_address() bcm63xx_enet: use dev_set_mac_address() instead of bcm_enet_set_mac_address() ethoc: add .ndo_validate_addr to net_device_ops lantiq_etop: use dev_set_mac_address() instead of ltq_etop_set_mac_address() neterion/s2io: fix s2io_set_mac_addr() to prevent double checks octeon: use dev_set_mac_address() instead of octeon_mgmt_set_mac_address() drivers/net/cris/eth_v10.c | 3 +-- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 2 +- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 13 ++++++++++--- drivers/net/ethernet/ethoc.c | 4 +--- drivers/net/ethernet/lantiq_etop.c | 4 ++-- drivers/net/ethernet/neterion/s2io.c | 5 +---- drivers/net/ethernet/octeon/octeon_mgmt.c | 6 ++---- include/linux/etherdevice.h | 2 +- include/linux/netdevice.h | 7 +++++-- net/core/dev.c | 7 ++++++- net/ethernet/eth.c | 12 +++++++++--- 11 files changed, 39 insertions(+), 26 deletions(-) -- 1.7.8.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/