Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757038Ab2CAAVJ (ORCPT ); Wed, 29 Feb 2012 19:21:09 -0500 Received: from mail-yw0-f46.google.com ([209.85.213.46]:38713 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756457Ab2CAAVF convert rfc822-to-8bit (ORCPT ); Wed, 29 Feb 2012 19:21:05 -0500 Authentication-Results: mr.google.com; spf=pass (google.com: domain of joshuacov@googlemail.com designates 10.236.77.102 as permitted sender) smtp.mail=joshuacov@googlemail.com; dkim=pass header.i=joshuacov@googlemail.com MIME-Version: 1.0 In-Reply-To: <4F4EBF44.60208@zytor.com> References: <4F4BF11E.4090000@zytor.com> <4F4C1F76.70403@zytor.com> <4F4D1E6A.5000200@zytor.com> <4F4E6B98.2090306@zytor.com> <4F4EB0B9.2080906@zytor.com> <4F4EBF44.60208@zytor.com> Date: Thu, 1 Mar 2012 01:21:04 +0100 Message-ID: Subject: Re: [RESUBMIT] [PATCH] Use BIOS Keyboard variable to set Numlock From: "Joshua C." To: "H. Peter Anvin" Cc: Bodo Eggert <7eggert@gmx.de>, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1449 Lines: 59 2012/3/1 H. Peter Anvin : > On 02/29/2012 03:51 PM, Joshua C. wrote: >> >> Will this work? >> >> +#if (defined(__i386__) || defined(__x86_64__)) >> +#include >> +#include >> +#else >> +extern struct boot_params boot_params; >> +#endif >> > > A much better way to do this is probably something like > > #ifdef CONFIG_X86 > > #include > > static inline int kbd_defleds(void) > { > ? ? ? ?return boot_param.kbd_status & 0x20 ? (1 << VC_NUMLOCK) : 0; > } > > #elif defined(CONFIG_PARISC) > static inline int kbd_defleds(void) > { > # if defined(CONFIG_KEYBOARD_HIL) || defined(CONFIG_KEYBOARD_HIL_OLD) > ? ? ? ?return 1 << VC_NUMLOCK; > # else > ? ? ? ?return 0; > # endif > } > > #else > > static inline int kbd_defleds(void) > { > ? ? ? ?return 0; > } > > #endif > > ... then arguably this should be moved into the arch/* directories, in a > header file or by making this a callable function. > > > -- > H. Peter Anvin, Intel Open Source Technology Center > I work for Intel. ?I don't speak on their behalf. > Thanks for the help. You can better figure out where this code should go into. Can you prepare the patch for merging in the mainline kernel? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/