Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751889Ab2EAEIR (ORCPT ); Tue, 1 May 2012 00:08:17 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:37826 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170Ab2EAEIP convert rfc822-to-8bit (ORCPT ); Tue, 1 May 2012 00:08:15 -0400 MIME-Version: 1.0 In-Reply-To: <4F9EEFB2.8030201@metafoo.de> References: <1335813977-8096-1-git-send-email-josephdanielwalter@gmail.com> <4F9EEFB2.8030201@metafoo.de> Date: Tue, 1 May 2012 10:08:14 +0600 Message-ID: Subject: Re: [PATCH] staging/iio/meter: fix the coding style problem From: joseph daniel To: Lars-Peter Clausen Cc: Jonathan Cameron , Greg Kroah-Hartman , Wolfram Sang , Paul Gortmaker , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1969 Lines: 53 On Tue, May 1, 2012 at 2:01 AM, Lars-Peter Clausen wrote: > On 04/30/2012 09:26 PM, joseph daniel wrote: >> Signed-off-by: joseph daniel >> --- >> Hi Lars, >> ? ? ? Thanks for review. how about the below change? >> ?drivers/staging/iio/meter/ade7854-i2c.c | ? ?6 +++++- >> ?1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/staging/iio/meter/ade7854-i2c.c b/drivers/staging/iio/meter/ade7854-i2c.c >> index 1e1faa0..52bdb05 100644 >> --- a/drivers/staging/iio/meter/ade7854-i2c.c >> +++ b/drivers/staging/iio/meter/ade7854-i2c.c >> @@ -181,6 +181,7 @@ static int ade7854_i2c_read_reg_32(struct device *dev, >> ?{ >> ? ? ? struct iio_dev *indio_dev = dev_get_drvdata(dev); >> ? ? ? struct ade7854_state *st = iio_priv(indio_dev); >> + ? ? uint32_t value; >> ? ? ? int ret; >> >> ? ? ? mutex_lock(&st->buf_lock); >> @@ -195,7 +196,10 @@ static int ade7854_i2c_read_reg_32(struct device *dev, >> ? ? ? if (ret) >> ? ? ? ? ? ? ? goto out; >> >> - ? ? *val = (st->rx[0] << 24) | (st->rx[1] << 16) | (st->rx[2] << 8) | st->rx[3]; >> + ? ? memcpy(&value, st->rx, sizeof(uint32_t)); >> + > > Uhm, yes, you are right st->rx is unaligned. The memcpy is not necessary though > if you use get_unaligned_be32. Sorry for the pointer to the wrong function. > > Btw. there are a few other locations in this driver which could use the > put_unaligned_be* and get_unaligned_be* functions. Would be great if you could > convert these as well. > >> + ? ? *val = be32_to_cpu(value); >> + >> ?out: >> ? ? ? mutex_unlock(&st->buf_lock); >> ? ? ? return ret; > Thanks for review. i will be glad doing those changes. i will send patch as soon as i get free. Thanks. Joseph. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/