Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754619Ab2EAJ7O (ORCPT ); Tue, 1 May 2012 05:59:14 -0400 Received: from merlin.infradead.org ([205.233.59.134]:54416 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754021Ab2EAJ7N convert rfc822-to-8bit (ORCPT ); Tue, 1 May 2012 05:59:13 -0400 Message-ID: <1335866334.13683.121.camel@twins> Subject: Re: [patch 4/5] mm + fs: provide refault distance to page cache instantiations From: Peter Zijlstra To: Johannes Weiner Cc: linux-mm@kvack.org, Rik van Riel , Andrea Arcangeli , Mel Gorman , Andrew Morton , Minchan Kim , Hugh Dickins , KOSAKI Motohiro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 01 May 2012 11:58:54 +0200 In-Reply-To: <20120501095543.GA2112@cmpxchg.org> References: <1335861713-4573-1-git-send-email-hannes@cmpxchg.org> <1335861713-4573-5-git-send-email-hannes@cmpxchg.org> <1335864640.13683.116.camel@twins> <20120501095543.GA2112@cmpxchg.org> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 936 Lines: 20 On Tue, 2012-05-01 at 11:55 +0200, Johannes Weiner wrote: > On Tue, May 01, 2012 at 11:30:40AM +0200, Peter Zijlstra wrote: > > On Tue, 2012-05-01 at 10:41 +0200, Johannes Weiner wrote: > > > Every site that does a find_or_create()-style allocation is converted > > > to pass this refault information to the page_cache_alloc() family of > > > functions, which in turn passes it down to the page allocator via > > > current->refault_distance. > > > > That is rather icky.. > > Fair enough, I just went with the easier solution to get things off > the ground instead of dealing with adding an extra parameter to layers > of config-dependent gfp API. I'll revisit this for v2. OK, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/