Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932097Ab2EAMxo (ORCPT ); Tue, 1 May 2012 08:53:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12835 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754764Ab2EAMxm (ORCPT ); Tue, 1 May 2012 08:53:42 -0400 Message-ID: <4F9FDCC4.3030302@redhat.com> Date: Tue, 01 May 2012 15:53:24 +0300 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Anthony Liguori CC: "Michael S. Tsirkin" , Marcelo Tosatti , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, davej@redhat.com Subject: Re: [PATCH] kvm: fix cpuid eax References: <20120430143902.GA10181@redhat.com> <4F9EF7FA.3060007@codemonkey.ws> In-Reply-To: <4F9EF7FA.3060007@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 816 Lines: 23 On 04/30/2012 11:37 PM, Anthony Liguori wrote: > On 04/30/2012 09:39 AM, Michael S. Tsirkin wrote: >> cpuid eax should return the max leaf so that >> guests can find out the valid range. >> This matches Xen et al. > > What KVM does here predates Xen and Hyper-V. > > This is an ABI breaker. First, I don't think we ever documented eax, so nothing can rely on it. Second, this isn't guest visible, it's just part of KVM_GET_SUPPORTED_CPUID (used by qemu's -cpu host, but doesn't affect qemu stable cpus). -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/