Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758395Ab2EAR47 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 1 May 2012 13:56:59 -0400
Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:61965 "EHLO
	mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1756713Ab2EAR45 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 1 May 2012 13:56:57 -0400
Message-ID: <4FA023E4.7000602@openvz.org>
Date: Tue, 01 May 2012 21:56:52 +0400
From: Konstantin Khlebnikov <khlebnikov@openvz.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120217 Firefox/10.0.2 Iceape/2.7.2
MIME-Version: 1.0
To: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
CC: "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH RFC 2/3] proc/smaps: show amount of nonlinear ptes in
 vma
References: <20120430112903.14137.81692.stgit@zurg> <20120430112907.14137.18910.stgit@zurg> <CAHGf_=pfiFJ4N3bN_c29UpffqkzDY_priBYBuEOCyPJ13JVecw@mail.gmail.com>
In-Reply-To: <CAHGf_=pfiFJ4N3bN_c29UpffqkzDY_priBYBuEOCyPJ13JVecw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2312
Lines: 53

KOSAKI Motohiro wrote:
> On Mon, Apr 30, 2012 at 7:29 AM, Konstantin Khlebnikov
> <khlebnikov@openvz.org>  wrote:
>> Currently, nonlinear mappings can not be distinguished from ordinary mappings.
>> This patch adds into /proc/pid/smaps line "Nonlinear:<size>  kB", where size is
>> amount of nonlinear ptes in vma, this line appears only if VM_NONLINEAR is set.
>> This information may be useful not only for checkpoint/restore project.
>>
>> Signed-off-by: Konstantin Khlebnikov<khlebnikov@openvz.org>
>> Requested-by: Pavel Emelyanov<xemul@parallels.com>
>> ---
>>   fs/proc/task_mmu.c |   12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>>
>> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
>> index acee5fd..b1d9729 100644
>> --- a/fs/proc/task_mmu.c
>> +++ b/fs/proc/task_mmu.c
>> @@ -393,6 +393,7 @@ struct mem_size_stats {
>>         unsigned long anonymous;
>>         unsigned long anonymous_thp;
>>         unsigned long swap;
>> +       unsigned long nonlinear;
>>         u64 pss;
>>   };
>>
>> @@ -402,6 +403,7 @@ static void smaps_pte_entry(pte_t ptent, unsigned long addr,
>>   {
>>         struct mem_size_stats *mss = walk->private;
>>         struct vm_area_struct *vma = mss->vma;
>> +       pgoff_t pgoff = linear_page_index(vma, addr);
>>         struct page *page = NULL;
>>         int mapcount;
>>
>> @@ -414,6 +416,9 @@ static void smaps_pte_entry(pte_t ptent, unsigned long addr,
>>                         mss->swap += ptent_size;
>>                 else if (is_migration_entry(swpent))
>>                         page = migration_entry_to_page(swpent);
>> +       } else if (pte_file(ptent)) {
>> +               if (pte_to_pgoff(ptent) != pgoff)
>> +                       mss->nonlinear += ptent_size;
>
> I think this is not equal to our non linear mapping definition. Even if
> pgoff is equal to linear mapping case, it is non linear. I.e. nonlinear is
> vma attribute. Why do you want to introduce different definition?

VMA attribute can be determined via presence of this field,
without VM_NONLINEAR it does not appears.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/