Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756324Ab2EAVTg (ORCPT ); Tue, 1 May 2012 17:19:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32087 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752829Ab2EAVTf (ORCPT ); Tue, 1 May 2012 17:19:35 -0400 Message-ID: <4FA05354.8000304@redhat.com> Date: Tue, 01 May 2012 17:19:16 -0400 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Andrew Morton CC: Johannes Weiner , linux-mm@kvack.org, Andrea Arcangeli , Peter Zijlstra , Mel Gorman , Minchan Kim , Hugh Dickins , KOSAKI Motohiro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch 0/5] refault distance-based file cache sizing References: <1335861713-4573-1-git-send-email-hannes@cmpxchg.org> <20120501120819.0af1e54b.akpm@linux-foundation.org> In-Reply-To: <20120501120819.0af1e54b.akpm@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1382 Lines: 33 On 05/01/2012 03:08 PM, Andrew Morton wrote: > On Tue, 1 May 2012 10:41:48 +0200 > Johannes Weiner wrote: > >> This series stores file cache eviction information in the vacated page >> cache radix tree slots and uses it on refault to see if the pages >> currently on the active list need to have their status challenged. > > So we no longer free the radix-tree node when everything under it has > been reclaimed? One could create workloads which would result in a > tremendous amount of memory used by radix_tree_node_cachep objects. > > So I assume these things get thrown away at some point. Some > discussion about the life-cycle here would be useful. I assume that in the current codebase Johannes has, we would have to rely on the inode cache shrinker to reclaim the inode and throw out the radix tree nodes. Having a better way to deal with radix tree nodes that contain stale entries (where the evicted pages would no longer receive special treatment on re-fault, because it has been so long) get reclaimed would be nice for a future version. Probably not too urgent, though... -- All rights reversed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/